You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2025/09/05 18:44:56 UTC
[PR] build: require Python 3.12+, add smoke-test Make target [lucene]
rmuir opened a new pull request, #15162:
URL: https://github.com/apache/lucene/pull/15162
Update Makefile and README to require Python 3.12 or newer, allow configurable Python executable, and add a 'smoke-test' target for smoketester. Update setup instructions and usage examples accordingly.
Closes #14556
Example error (with minimum bumped to 3.14):
<img width="944" height="223" alt="Screen_Shot_2025-09-05_at_14 40 29" src="https://github.com/user-attachments/assets/446850fa-aa3f-4e4d-9f5d-f49bcccd15c4" />
If we can just use the `make` command, it will make life easier than user having to install python dependencies. It also won't mess up any other python stuff on their computer because it uses a virtual environment, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] build: require Python 3.12+, add smoke-test Make target [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15162:
URL: https://github.com/apache/lucene/pull/15162#issuecomment-3259404228
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] build: require Python 3.12+, add smoke-test Make target [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #15162:
URL: https://github.com/apache/lucene/pull/15162#issuecomment-3293476300
I think it would be an improvement to call it in the action. The goal here was just to present a less error-prone way of running the smoke-tester, so it is ideal to test that way too:
* doesn't install a bunch of python libs globally on your machine which may mess stuff up
* give better error messages if something is wrong
* possibility to improve later to make it more reliable: e.g. use lockfile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] build: require Python 3.12+, add smoke-test Make target [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #15162:
URL: https://github.com/apache/lucene/pull/15162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] build: require Python 3.12+, add smoke-test Make target [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15162:
URL: https://github.com/apache/lucene/pull/15162#issuecomment-3293261437
Ok, nevermind - I think it's fine even if we don't use venv there in that workflow, the container should have an up to date version of all dependencies. I'll follow up if it breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] build: require Python 3.12+, add smoke-test Make target [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15162:
URL: https://github.com/apache/lucene/pull/15162#issuecomment-3293482243
Yes, it's fine with me - feel free to merge, I'll follow-up with workflows changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org