You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/10 20:45:58 UTC
[GitHub] [geode] jhutchison opened a new pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees
jhutchison opened a new pull request #5505:
URL: https://github.com/apache/geode/pull/5505
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5505:
URL: https://github.com/apache/geode/pull/5505#discussion_r486648342
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -2999,6 +2999,7 @@ private boolean putInBucket(final InternalDistributedMember targetNode, final In
try {
final boolean isLocal = (this.localMaxMemory > 0) && currentTarget.equals(getMyId());
+ logger.info(primaryMoveReadLockAcquired);
Review comment:
remove this logger statement. I think it broke your build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhutchison commented on a change in pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees
Posted by GitBox <gi...@apache.org>.
jhutchison commented on a change in pull request #5505:
URL: https://github.com/apache/geode/pull/5505#discussion_r486662995
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -2999,6 +2999,7 @@ private boolean putInBucket(final InternalDistributedMember targetNode, final In
try {
final boolean isLocal = (this.localMaxMemory > 0) && currentTarget.equals(getMyId());
+ logger.info(primaryMoveReadLockAcquired);
Review comment:
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5505:
URL: https://github.com/apache/geode/pull/5505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhutchison commented on pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees
Posted by GitBox <gi...@apache.org>.
jhutchison commented on pull request #5505:
URL: https://github.com/apache/geode/pull/5505#issuecomment-690760631
> Looks good. I'd like to request two minor changes in the file redis_api_for_geode.html.md.erb:
>
> * In the heading "High Availability Model, Guarantees & Redis Client Responsibilities", replace the ampersand with the word "and"
> * In the sentence "As persistence is not currently supported,..." drop the word "currently". This constitutes a promise to change the functionality at an unspecified future date. Let's not go there.
> Thanks for contributing to the docs!
done. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org