You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 07:50:00 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9314: [Rust] Fix deprecation warning in clippy
jorgecarleitao opened a new pull request #9314:
URL: https://github.com/apache/arrow/pull/9314
Master and all PRs are failing with a deprecation warning in clippy. This fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9314: ARROW-11375: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766857041
https://issues.apache.org/jira/browse/ARROW-11375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766731276
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=h1) Report
> Merging [#9314](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=desc) (d427d8f) into [master](https://codecov.io/gh/apache/arrow/commit/cf7638fd61a9371630db63ebe866fbc4693d482f?el=desc) (cf7638f) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9314 +/- ##
==========================================
- Coverage 81.89% 81.88% -0.01%
==========================================
Files 215 215
Lines 52988 52988
==========================================
- Hits 43392 43391 -1
- Misses 9596 9597 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9314/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=footer). Last update [cf7638f...d427d8f](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766731276
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=h1) Report
> Merging [#9314](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=desc) (a4572d2) into [master](https://codecov.io/gh/apache/arrow/commit/cf7638fd61a9371630db63ebe866fbc4693d482f?el=desc) (cf7638f) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9314 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 215 215
Lines 52988 52988
=======================================
Hits 43392 43392
Misses 9596 9596
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=footer). Last update [cf7638f...a4572d2](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766767675
It seems like perhaps this is related to the release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766625620
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766731276
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=h1) Report
> Merging [#9314](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=desc) (a4572d2) into [master](https://codecov.io/gh/apache/arrow/commit/cf7638fd61a9371630db63ebe866fbc4693d482f?el=desc) (cf7638f) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9314 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 215 215
Lines 52988 52988
=======================================
Hits 43392 43392
Misses 9596 9596
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=footer). Last update [cf7638f...a4572d2](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9314: ARROW-11375: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9314:
URL: https://github.com/apache/arrow/pull/9314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766731276
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=h1) Report
> Merging [#9314](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=desc) (d427d8f) into [master](https://codecov.io/gh/apache/arrow/commit/cf7638fd61a9371630db63ebe866fbc4693d482f?el=desc) (cf7638f) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9314 +/- ##
==========================================
- Coverage 81.89% 81.88% -0.01%
==========================================
Files 215 215
Lines 52988 52988
==========================================
- Hits 43392 43391 -1
- Misses 9596 9597 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9314/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=footer). Last update [cf7638f...d427d8f](https://codecov.io/gh/apache/arrow/pull/9314?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766767675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766853907
<img width="931" alt="Screen Shot 2021-01-25 at 9 28 56 AM" src="https://user-images.githubusercontent.com/490673/105718929-bf9f1280-5eef-11eb-85e1-e782396639c2.png">
Looking clean and green 💚
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766796537
It should be fixed now. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9314: ARROW-11375: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9314:
URL: https://github.com/apache/arrow/pull/9314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766625620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766775550
The `Clippy` test still is failing; I found I had to run `cargo update` in my local arrow checkout to reproduce the failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766796537
It should be fixed now. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9314: [Rust] Fix deprecation warning in clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9314:
URL: https://github.com/apache/arrow/pull/9314#issuecomment-766854937
I will file a JIRA ticket and merge this in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org