You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2014/12/19 19:37:39 UTC

svn commit: r1646814 - in /pdfbox/trunk/pdfbox/src: main/java/org/apache/pdfbox/pdmodel/interactive/form/PDVariableText.java test/java/org/apache/pdfbox/pdmodel/interactive/form/TestFields.java

Author: msahyoun
Date: Fri Dec 19 18:37:39 2014
New Revision: 1646814

URL: http://svn.apache.org/r1646814
Log:
PDFBOX-2516 return Java types instead of COS model types

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDVariableText.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestFields.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDVariableText.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDVariableText.java?rev=1646814&r1=1646813&r2=1646814&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDVariableText.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDVariableText.java Fri Dec 19 18:37:39 2014
@@ -257,12 +257,12 @@ public abstract class PDVariableText ext
      * The default style string defines the default style for
      * rich text fields.
      * 
-     * @return the DD element of the dictionary object
+     * @return the DS element of the dictionary object
      */
-    public COSString getDefaultStyleString()
+    public String getDefaultStyleString()
     {
-        COSBase defaultStyleString = getDictionary().getDictionaryObject(COSName.DS);
-        return (COSString) defaultStyleString;
+        COSString defaultStyleString = (COSString) getDictionary().getDictionaryObject(COSName.DS);
+        return defaultStyleString.getString();
     }
 
     /**

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestFields.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestFields.java?rev=1646814&r1=1646813&r2=1646814&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestFields.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestFields.java Fri Dec 19 18:37:39 2014
@@ -158,7 +158,6 @@ public class TestFields extends TestCase
             
             // get the TextField with a DV entry
             field = form.getField("TextField-DefaultValue");
-            System.out.println(field.getClass().getName());
             assertNotNull(field);
             assertEquals(field.getDefaultValue(),"DefaultValue");
             assertEquals(field.getDefaultValue(),
@@ -167,14 +166,13 @@ public class TestFields extends TestCase
 
             // get a rich text field with a  DV entry
             field = form.getField("RichTextField-DefaultValue");
-            System.out.println(field.getClass().getName());
             assertNotNull(field);
             assertEquals(field.getDefaultValue(),"DefaultValue");
             assertEquals(field.getDefaultValue(),
                     ((COSString)field.getDictionary().getDictionaryObject(COSName.DV)).getString());
             assertEquals(field.getValue(), "DefaultValue");
             assertEquals(((PDVariableText)field).getDefaultAppearance().getString(), "/Helv 12 Tf 0 g");
-            assertEquals(((PDVariableText)field).getDefaultStyleString().getString(),
+            assertEquals(((PDVariableText)field).getDefaultStyleString(),
                     "font: Helvetica,sans-serif 12.0pt; text-align:left; color:#000000 ");
             // do not test for the full content as this is a rather long xml string
             assertEquals(((PDVariableText)field).getRichTextValue().length(),338);