[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5353: HDFS-16909. Make judging null statment out from for loop in ReplicaMap#mergeAll method.

["hfutatzhanghb (via GitHub)" <gi...@apache.org>]

hfutatzhanghb commented on code in PR #5353:
URL: https://github.com/apache/hadoop/pull/5353#discussion_r1198943812


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java:
##########
@@ -178,13 +178,13 @@ void mergeAll(ReplicaMap other) {
         for (ReplicaInfo replicaInfo : replicaInfos) {
           replicaSet.add(replicaInfo);
         }
+        if (curSet == null) {

Review Comment:
   @Hexiaoqiao , done. Thanks a lot for this suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org