[jira] [Comment Edited] (FLINK-31812) SavePoint from /jars/:jarid:/run api on body is not anymore set to null if empty

["Weijie Guo (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-31812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713513#comment-17713513 ] 

Weijie Guo edited comment on FLINK-31812 at 4/18/23 9:57 AM:
-------------------------------------------------------------

IIUC, It seems that this [change|https://github.com/apache/flink/pull/21012/files#diff-c6d9a43d970eb07642a87e4bf9ec6a9dc7d363b1b5b557ed76f73d8de1cc5a54R145] in FLINK-29543 is not unnecessary. 
cc [~ConradJam] for more context.


was (Author: weijie guo):
UUIC, It seems that this [change|https://github.com/apache/flink/pull/21012/files#diff-c6d9a43d970eb07642a87e4bf9ec6a9dc7d363b1b5b557ed76f73d8de1cc5a54R145] in FLINK-29543 is not unnecessary. 
cc [~ConradJam] for more context.

> SavePoint from /jars/:jarid:/run api on body is not anymore set to null if empty
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-31812
>                 URL: https://issues.apache.org/jira/browse/FLINK-31812
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.17.0
>            Reporter: Nicolas Fraison
>            Priority: Minor
>              Labels: pull-request-available
>
> Since https://issues.apache.org/jira/browse/FLINK-29543 the 
> savepointPath from the body is not anymore transform to null if empty: [https://github.com/apache/flink/pull/21012/files#diff-c6d9a43d970eb07642a87e4bf9ec6a9dc7d363b1b5b557ed76f73d8de1cc5a54R145]
>  
> This leads to issue running a flink job in release 1.17 with lyft operator which set savePoint in body to empty string: [https://github.com/lyft/flinkk8soperator/blob/master/pkg/controller/flinkapplication/flink_state_machine.go#L721]
>  
> Issue faced by the job as the savepointPath is setto empty string:
> {code:java}
> org.apache.flink.runtime.client.JobInitializationException: Could not start the JobMaster.
> 3	at org.apache.flink.runtime.jobmaster.DefaultJobMasterServiceProcess.lambda$new$0(DefaultJobMasterServiceProcess.java:97)
> 4	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859)
> 5	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:837)
> 6	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)
> 7	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1705)
> 8	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> 9	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> 10	at java.base/java.lang.Thread.run(Thread.java:829)
> 11Caused by: java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: empty checkpoint pointer
> 12	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
> 13	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
> 14	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)
> 15	... 3 more
> 16Caused by: java.lang.IllegalArgumentException: empty checkpoint pointer
> 17	at org.apache.flink.util.Preconditions.checkArgument(Preconditions.java:138)
> 18	at org.apache.flink.runtime.state.filesystem.AbstractFsCheckpointStorageAccess.resolveCheckpointPointer(AbstractFsCheckpointStorageAccess.java:240)
> 19	at org.apache.flink.runtime.state.filesystem.AbstractFsCheckpointStorageAccess.resolveCheckpoint(AbstractFsCheckpointStorageAccess.java:136)
> 20	at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.restoreSavepoint(CheckpointCoordinator.java:1824)
> 21	at org.apache.flink.runtime.scheduler.DefaultExecutionGraphFactory.tryRestoreExecutionGraphFromSavepoint(DefaultExecutionGraphFactory.java:223)
> 22	at org.apache.flink.runtime.scheduler.DefaultExecutionGraphFactory.createAndRestoreExecutionGraph(DefaultExecutionGraphFactory.java:198)
> 23	at org.apache.flink.runtime.scheduler.SchedulerBase.createAndRestoreExecutionGraph(SchedulerBase.java:365)
> 24	at org.apache.flink.runtime.scheduler.SchedulerBase.<init>(SchedulerBase.java:210)
> 25	at org.apache.flink.runtime.scheduler.DefaultScheduler.<init>(DefaultScheduler.java:136)
> 26	at org.apache.flink.runtime.scheduler.DefaultSchedulerFactory.createInstance(DefaultSchedulerFactory.java:152)
> 27	at org.apache.flink.runtime.jobmaster.DefaultSlotPoolServiceSchedulerFactory.createScheduler(DefaultSlotPoolServiceSchedulerFactory.java:119)
> 28	at org.apache.flink.runtime.jobmaster.JobMaster.createScheduler(JobMaster.java:371)
> 29	at org.apache.flink.runtime.jobmaster.JobMaster.<init>(JobMaster.java:348)
> 30	at org.apache.flink.runtime.jobmaster.factories.DefaultJobMasterServiceFactory.internalCreateJobMasterService(DefaultJobMasterServiceFactory.java:123)
> 31	at org.apache.flink.runtime.jobmaster.factories.DefaultJobMasterServiceFactory.lambda$createJobMasterService$0(DefaultJobMasterServiceFactory.java:95)
> 32	at org.apache.flink.util.function.FunctionUtils.lambda$uncheckedSupplier$4(FunctionUtils.java:112)
> 33	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
> 34	... 3 more
> 35 {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)