You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "KeeProMise (via GitHub)" <gi...@apache.org> on 2023/04/09 13:43:33 UTC

[GitHub] [incubator-kvrocks] KeeProMise opened a new issue, #1376: Is it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.

KeeProMise opened a new issue, #1376:
URL: https://github.com/apache/incubator-kvrocks/issues/1376

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   I downloaded docker Mirror, found that you need to install redis-cli yourself,s it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1376: Is it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1376:
URL: https://github.com/apache/incubator-kvrocks/issues/1376#issuecomment-1501348055

   When you "enter" the docker container via shell, you change the entrypoint of the docker image from `kvrocks` to `bash` (or the posix shell). We do not expect users to do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1376: Is it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1376:
URL: https://github.com/apache/incubator-kvrocks/issues/1376#issuecomment-1501139783

   This sounds good to me. cc @torwig @PragmaTwice @ShooterIT 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1376: Is it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1376:
URL: https://github.com/apache/incubator-kvrocks/issues/1376#issuecomment-1501142175

   I do not think it is necessary. The docker image we provide is only for starting a kvrocks service, not a redis client.
   
   You can build a docker image only for redis-cli, find one in the docker hub, or use redis-cli in your host environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] KeeProMise commented on issue #1376: Is it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.

Posted by "KeeProMise (via GitHub)" <gi...@apache.org>.
KeeProMise commented on issue #1376:
URL: https://github.com/apache/incubator-kvrocks/issues/1376#issuecomment-1501328135

   > We don't need to modify the entrypoint, I think redis-cli can be added to the bin directory, so that for some people who are new to the database, it is very convenient (enter the docker container to run bin/redis-cli) to execute some redis commands to interact with the database. Moreover, the same is true for mysql, redis, iotdb, etc. that I know.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org