[GitHub] spark pull request #14048: [SPARK-16370][SQL] Union queries should not be ex...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14048#discussion_r69659069
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -184,7 +183,8 @@ class Dataset[T] private[sql](
           // to happen right away to let these side effects take place eagerly.
           case p if hasSideEffects(p) =>
             LogicalRDD(queryExecution.analyzed.output, queryExecution.toRdd)(sparkSession)
    -      case Union(children) if children.forall(hasSideEffects) =>
    +      case Union(children) if children.forall(x =>
    +          x.isInstanceOf[InsertIntoTable] || x.isInstanceOf[InsertIntoHadoopFsRelationCommand]) =>
    --- End diff --
    
    what are we fixing here? `hasSideEffects` looks clearer than `x.isInstanceOf[InsertIntoTable] || x.isInstanceOf[InsertIntoHadoopFsRelationCommand]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org