You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2025/08/04 01:38:28 UTC
[PR] Asset plugin forking compiler [grails-core]
jdaugherty opened a new pull request, #14948:
URL: https://github.com/apache/grails-core/pull/14948
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Asset plugin forking compiler [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #14948:
URL: https://github.com/apache/grails-core/pull/14948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Asset plugin forking compiler [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #14948:
URL: https://github.com/apache/grails-core/pull/14948#discussion_r2251311429
##########
build.gradle:
##########
@@ -57,6 +57,15 @@ allprojects {
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*-SNAPSHOT')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
Isn't this repository config only for fetching/reading dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Asset plugin forking compiler [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #14948:
URL: https://github.com/apache/grails-core/pull/14948#discussion_r2251257772
##########
build.gradle:
##########
@@ -57,6 +57,15 @@ allprojects {
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*-SNAPSHOT')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
We almost accidentally published a release version to snapshot, so yes i think its necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Asset plugin forking compiler [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #14948:
URL: https://github.com/apache/grails-core/pull/14948#discussion_r2251040090
##########
build.gradle:
##########
@@ -57,6 +57,15 @@ allprojects {
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*-SNAPSHOT')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
Is this necessary considering the version regex filter above?
##########
build.gradle:
##########
@@ -57,6 +57,15 @@ allprojects {
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*-SNAPSHOT')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
Review Comment:
Align on parentheses for method calls?
##########
dependencies.gradle:
##########
@@ -25,7 +25,7 @@ ext {
'ant.version' : '1.10.15',
'asciidoctor-gradle-jvm.version' : '4.0.4',
'asciidoctorj.version' : '3.0.0',
- 'asset-pipeline-gradle.version' : '5.0.12',
+ 'asset-pipeline-gradle.version': '5.0.14',
Review Comment:
Spacing?
##########
grails-forge/build.gradle:
##########
@@ -62,6 +62,15 @@ allprojects {
includeGroupByRegex('org[.]apache[.]grails.*')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
See previous comments.
##########
grails-gradle/buildSrc/build.gradle:
##########
@@ -29,6 +29,15 @@ repositories {
// mavenLocal()
mavenCentral()
gradlePluginPortal()
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
See previous comments.
##########
buildSrc/build.gradle:
##########
@@ -38,6 +38,15 @@ repositories {
}
}
maven { url = 'https://repo.grails.org/grails/restricted' }
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
See previous comments.
##########
grails-forge/buildSrc/build.gradle:
##########
@@ -57,6 +57,15 @@ repositories {
includeGroupByRegex('org[.]apache[.]grails.*')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
See previous comments.
##########
grails-gradle/build.gradle:
##########
@@ -36,6 +36,15 @@ allprojects {
includeVersionByRegex('org[.]apache[.](grails|groovy).*', '.*', '.*SNAPSHOT')
}
}
+ maven {
+ url = 'https://central.sonatype.com/repository/maven-snapshots'
+ content {
+ includeVersionByRegex 'cloud[.]wondrify.*', '.*', '.*-SNAPSHOT'
+ }
+ mavenContent {
+ snapshotsOnly()
+ }
Review Comment:
See previous comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Asset plugin forking compiler [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14948:
URL: https://github.com/apache/grails-core/pull/14948#issuecomment-3148980395
Updated for the issue found on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org