You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2016/08/29 16:05:22 UTC
[GitHub] activemq-artemis pull request #738: ARTEMIS-696 Broker fails when client sen...
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/738
ARTEMIS-696 Broker fails when client sends messages in multiple transfer frames
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis artemis_maxFrameSize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/738.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #738
----
commit 55cc1feb4c8f5007ff758f91d569fbfd086f8f33
Author: Howard Gao <ho...@gmail.com>
Date: 2016-08-24T13:54:08Z
ARTEMIS-696 Broker fails when client sends messages in multiple transfer frames
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #738: ARTEMIS-696 Broker fails when client sen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/738
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #738: ARTEMIS-696 Broker fails when client sends mess...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/738
@clebertsuconic no I didn't run the whole suite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #738: ARTEMIS-696 Broker fails when client sends mess...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/738
This is apparently good. I need to do some tests today.
Did you run the whole testsuite on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #738: ARTEMIS-696 Broker fails when client sen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/738#discussion_r76881991
--- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/server/ProtonServerReceiverContext.java ---
@@ -116,7 +116,10 @@ public void onMessage(Delivery delivery) throws ActiveMQAMQPException {
receiver = ((Receiver) delivery.getLink());
if (!delivery.isReadable()) {
--- End diff --
@gaohoward Actually... lets keep it this way.. no need...
merging it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #738: ARTEMIS-696 Broker fails when client sen...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/738#discussion_r76818244
--- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/server/ProtonServerReceiverContext.java ---
@@ -116,7 +116,10 @@ public void onMessage(Delivery delivery) throws ActiveMQAMQPException {
receiver = ((Receiver) delivery.getLink());
if (!delivery.isReadable()) {
--- End diff --
ok, will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #738: ARTEMIS-696 Broker fails when client sends mess...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/738
@mtaylor Yep.. I always do :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #738: ARTEMIS-696 Broker fails when client sends mess...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/738
@gaohoward I started a run on my box.. np
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #738: ARTEMIS-696 Broker fails when client sends mess...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/738
@mtaylor I updated the proton-j api to use exisiting one (after consulting tim) and opened this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #738: ARTEMIS-696 Broker fails when client sen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/738#discussion_r76802715
--- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/server/ProtonServerReceiverContext.java ---
@@ -116,7 +116,10 @@ public void onMessage(Delivery delivery) throws ActiveMQAMQPException {
receiver = ((Receiver) delivery.getLink());
if (!delivery.isReadable()) {
--- End diff --
This was supopsed to be logger.trace()... can you do a logger.trace instead of removing it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---