[GitHub] [hive] kasakrisz commented on a change in pull request #2536: HIVE-25370: Improve SharedWorkOptimizer performance

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #2536:
URL: https://github.com/apache/hive/pull/2536#discussion_r677355991



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##########
@@ -388,6 +384,10 @@ public boolean sharedWorkOptimization(ParseContext pctx, SharedWorkOptimizerCach
         continue;
       }
       for (TableScanOperator retainableTsOp : retainedScans) {
+        if (optimizerCache.getWorkGroup(discardableTsOp).contains(retainableTsOp)) {
+          LOG.trace("No need check further {} and {} is in the same group", discardableTsOp, retainableTsOp);

Review comment:
       nit: `are` in the same




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org