Re: [PR] [Fix](Variant) fix variant schema change may cause invalid block schema and write missing blocks [doris]

["xiaokang (via GitHub)" <gi...@apache.org>]

xiaokang commented on code in PR #36317:
URL: https://github.com/apache/doris/pull/36317#discussion_r1641599791


##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -315,14 +315,15 @@ Status SegmentCreator::add_block(const vectorized::Block* block) {
     size_t block_row_num = block->rows();
     size_t row_avg_size_in_bytes = std::max((size_t)1, block_size_in_bytes / block_row_num);
     size_t row_offset = 0;
-
     if (_segment_flusher.need_buffering()) {
+        RETURN_IF_ERROR(_buffer_block.merge(*block));

Review Comment:
   need more discussion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org