You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/09 14:59:28 UTC

[GitHub] [airflow] ashb edited a comment on pull request #14631: Add Dynamic fields to Snowflake Connection

ashb edited a comment on pull request #14631:
URL: https://github.com/apache/airflow/pull/14631#issuecomment-794009405


   > We should not suggest to save secrets in extra field if it's not encrypted.
   > We have the same issue with Salesforce #8766
   
   I don't think there is anything sensitive in the extra field here, is there @eladkal?
   
   ```
           account = conn.extra_dejson.get('extra__snowflake__account', '')
           warehouse = conn.extra_dejson.get('extra__snowflake__warehouse', '')
           database = conn.extra_dejson.get('extra__snowflake__database', '')
           region = conn.extra_dejson.get('extra__snowflake__region', '')
   ```
   
   Those all seem safe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org