You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by kpm1985 <gi...@git.apache.org> on 2017/07/21 20:59:00 UTC
[GitHub] logging-log4j2 pull request #96: Remove empty comments and fix default buffe...
GitHub user kpm1985 opened a pull request:
https://github.com/apache/logging-log4j2/pull/96
Remove empty comments and fix default buffer size to match documentation.
I have removed empty comments and changed the default buffer sizes in certain implementations to match the documentation, specifically changing from 8102 to 8192. I believe these changes are cleaner than the last PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kpm1985/logging-log4j2 cleanups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit 4e730b5d5cb8b5bd886326566f3b2a84f9c3bb6f
Author: Kenneth <ke...@gmail.com>
Date: 2017-07-19T23:00:46Z
remove unnecessary/empty comment
commit 5ae0124ff40a3fd7e0c6543978023b6d46eeb66b
Author: Kenneth McFarland <ke...@kenneths-macbook.local>
Date: 2017-07-20T22:47:28Z
Cleanup
commit 053beb05997fe21b60b4ef787c07065c5b402c87
Author: Kenneth <ke...@gmail.com>
Date: 2017-07-21T03:59:51Z
merge conflicts
commit 53e38eeab42908a3fcad94fbf2569d83c947b6ce
Author: Kenneth <ke...@gmail.com>
Date: 2017-07-21T20:43:32Z
Let default buffer sizes equal 8192 to match documentation
commit 5ef85174ee2ba3ef7a3e4fb9ab65c33ecea634f6
Author: Kenneth <ke...@gmail.com>
Date: 2017-07-21T20:48:10Z
Remove empty comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #96: Remove empty comments and fix default buffer size ...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/96
On Jul 21, 2017 21:36, "asfbot" <no...@github.com> wrote:
kenneth mcfarland on dev@logging.apache.org replies:
I noticed you created a JIRA for the 8012 buf size defualt. Is this
something I should do when I'm doing something more than a typo fix?
Yes, this helps us keep track of things.
Thank you,
Gary
Thank you =F0=9F=98=80
re
t
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/apache/logging-log4j2/pull/96#issuecomment-317154323>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABIfN1GulwZY0sCZw7J6NEjVHSB04lc1ks5sQXxdgaJpZM4Of4ui>
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 pull request #96: Remove empty comments and fix default buffe...
Posted by kpm1985 <gi...@git.apache.org>.
Github user kpm1985 closed the pull request at:
https://github.com/apache/logging-log4j2/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] logging-log4j2 issue #96: Remove empty comments and fix
default buffer size ...
Posted by kenneth mcfarland <ke...@gmail.com>.
I noticed you created a JIRA for the 8012 buf size defualt. Is this
something I should do when I'm doing something more than a typo fix?
Thank you 😀
On Jul 21, 2017 2:16 PM, "kenneth mcfarland" <ke...@gmail.com>
wrote:
> Sure will, new to git sorry. Still figuring it out.
>
> On Jul 21, 2017 2:14 PM, "garydgregory" <gi...@git.apache.org> wrote:
>
>> Github user garydgregory commented on the issue:
>>
>> https://github.com/apache/logging-log4j2/pull/96
>>
>> Thank you for your patch but I've already applied
>> https://github.com/apache/logging-log4j2/pull/95 Can you merge and
>> resubmit SVP?
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
Re: [GitHub] logging-log4j2 issue #96: Remove empty comments and fix
default buffer size ...
Posted by kenneth mcfarland <ke...@gmail.com>.
Sure will, new to git sorry. Still figuring it out.
On Jul 21, 2017 2:14 PM, "garydgregory" <gi...@git.apache.org> wrote:
> Github user garydgregory commented on the issue:
>
> https://github.com/apache/logging-log4j2/pull/96
>
> Thank you for your patch but I've already applied
> https://github.com/apache/logging-log4j2/pull/95 Can you merge and
> resubmit SVP?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] logging-log4j2 issue #96: Remove empty comments and fix default buffer size ...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/96
Thank you for your patch but I've already applied https://github.com/apache/logging-log4j2/pull/95 Can you merge and resubmit SVP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---