[jira] [Commented] (GIRAPH-224) Server-side combiner

["Alessandro Presta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403978#comment-13403978 ] 

Alessandro Presta commented on GIRAPH-224:
------------------------------------------

I did this in BspServiceWorker, let me know if it's right or I misunderstood the task.

Had to handle IOException from combine(), even though no implementation currently throws that.
I guess it's there for potential implementations where messages are read from disk?
                
> Server-side combiner
> --------------------
>
>                 Key: GIRAPH-224
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-224
>             Project: Giraph
>          Issue Type: Improvement
>          Components: bsp
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-224.patch
>
>
> Currently, if a VertexCombiner is defined in the Configuration, we use it on the client in order to optimize bandwidth and memory usage.
> On the server side, we can easily benefit in terms of memory by exploiting the combiner once more.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira