You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/29 01:41:39 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28063: [SPARK-31293][DSTREAMS][Kinesis][DOC] Fix wrong examples and help messages for Kinesis integration

dongjoon-hyun commented on a change in pull request #28063: [SPARK-31293][DSTREAMS][Kinesis][DOC] Fix wrong examples and help messages for Kinesis integration
URL: https://github.com/apache/spark/pull/28063#discussion_r399731820
 
 

 ##########
 File path: external/kinesis-asl/src/main/python/examples/streaming/kinesis_wordcount_asl.py
 ##########
 @@ -34,10 +35,9 @@
       $ export AWS_SECRET_KEY=<your-secret-key>
 
       # run the example
-      $ bin/spark-submit -jars external/kinesis-asl/target/scala-*/\
-        spark-streaming-kinesis-asl-assembly_*.jar \
+      $ bin/spark-submit --jars 'external/kinesis-asl-assembly/target/spark-streaming-kinesis-asl-assembly_*.jar' \
 
 Review comment:
   Thank you for your contribution, @sekikn . Could you fix the Python style violation?
   ```
   ./external/kinesis-asl/src/main/python/examples/streaming/kinesis_wordcount_asl.py:38:101: E501 line too long (115 > 100 characters)
   [error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-python ; received return code 1
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org