You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Biestro (JIRA)" <ji...@apache.org> on 2018/12/17 15:46:00 UTC
[jira] [Resolved] (JEXL-281) MethodExecutor incorrectly tests for
empty parameters list
[ https://issues.apache.org/jira/browse/JEXL-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro resolved JEXL-281.
--------------------------------
Resolution: Fixed
Fix Version/s: 3.2
- releases notes and changes
revision : e7d212e423cd409bdd049864e77b0521ea5e4c10
> MethodExecutor incorrectly tests for empty parameters list
> ----------------------------------------------------------
>
> Key: JEXL-281
> URL: https://issues.apache.org/jira/browse/JEXL-281
> Project: Commons JEXL
> Issue Type: Bug
> Affects Versions: 3.1
> Reporter: Mirek Hankus
> Assignee: Henri Biestro
> Priority: Major
> Fix For: 3.2
>
>
> Currently MethodExecutor constructor contains code
> {code:java}
> if (method != null) {
> Class<?>[] formal = method.getParameterTypes();
> // if the last parameter is an array, the method is considered as vararg
> if (formal != null && MethodKey.isVarArgs(method)) {
> vastart = formal.length - 1;
> vaclass = formal[vastart].getComponentType();
> }
> }{code}
> variable formal is never null, beacause Javadoc for getParameterTypes states that "returns an array of length 0 if the underlying executable takes no parameters." (implementation invokes clone - so there always be an object)
> So test for empty parameter list should not test for null, but for empty array -
> {code:java}
> if (formal.length > 0 && MethodKey.isVarArgs(method)) {{code}
> .
> Problem is that MethodKey.isVarArgs is very costly (it traverses class hierarchy, and throws Exception for every object which does not have method by this name) - so invocation of isVarArgs should be avoided if not required. Currently it is always called due to wrong test condition
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)