You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/01 17:55:16 UTC
[GitHub] [ozone] umamaheswararao commented on a change in pull request #2687: HDDS-5741. EC: Remove hard coded chunksize and get from from ReplicationConfig
umamaheswararao commented on a change in pull request #2687:
URL: https://github.com/apache/ozone/pull/2687#discussion_r720436996
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -60,7 +59,7 @@
public class ECKeyOutputStream extends KeyOutputStream {
private OzoneClientConfig config;
private ECChunkBuffers ecChunkBufferCache;
- private int ecChunkSize = 1024;
+ private int ecChunkSize;
private final int numDataBlks;
private final int numParityBlks;
private static final ByteBufferPool BUFFER_POOL = new ElasticByteBufferPool();
Review comment:
Below there is a hardcodec codec name. You may want to take it from replication config?
private static final String DEFAULT_CODEC_NAME = "rs";
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -1408,7 +1409,8 @@ private OzoneOutputStream createOutputStream(OpenKeySession openKey,
keyOutputStream = new ECKeyOutputStream.Builder().setHandler(openKey)
.setXceiverClientManager(xceiverClientManager)
.setOmClient(ozoneManagerClient).setRequestID(requestId)
- .setReplicationConfig(openKey.getKeyInfo().getReplicationConfig())
+ .setReplicationConfig((
+ (ECReplicationConfig)openKey.getKeyInfo().getReplicationConfig()))
Review comment:
Nit: we can remove redundant brackets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org