You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/06/12 14:40:26 UTC

[kudu-CR] [WIP] Implement owner privileges

Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16072


Change subject: [WIP] Implement owner privileges
......................................................................

[WIP] Implement owner privileges

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
M src/kudu/security/simple_acl.h
10 files changed, 189 insertions(+), 126 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 19:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16072/18/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java:

http://gerrit.cloudera.org:8080/#/c/16072/18/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@172
PS18, Line 172: requi
> nit: requiresAdmin is more clear
Done


http://gerrit.cloudera.org:8080/#/c/16072/18/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@173
PS18, Line 173: est.g
> nit: isOwner is more clear
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 19
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 14:06:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 19: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 19
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 17:51:14 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#21).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 304 insertions(+), 150 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/21
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 21
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 15:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

PS15: 
Can you also add a test for the case where a user gives its ownership away to another user and is then unable to access the table, while the other user can?


http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@935
PS15, Line 935: t
nit: capitalize and add a period


http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063
PS15, Line 1063: string user;
               :                           if (std::get<2>(info.param) == kTestUser) {
               :                             user = "testuser";
               :                           } else if (std::get<2>(info.param) == "{OWNER}") {
               :                             user = "owner";
               :                           }
nit: maybe be simpler as

string user = kTestUser;
if (std::get<2>(info.param) == "{OWNER}") {
  user = "owner";
}

Same above


http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/master/catalog_manager.cc@1978
PS15, Line 1978: if
nit: capitalize this



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 08 Jul 2020 02:46:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#5).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 297 insertions(+), 132 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/5
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 7:

unrelated flaky test


-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 26 Jun 2020 12:47:46 +0000
Gerrit-HasComments: No

[kudu-CR] [WIP] Implement owner privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#3).

Change subject: [WIP] Implement owner privileges
......................................................................

[WIP] Implement owner privileges

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/ranger/TestRangerSubprocess.java
M java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/ranger/authorization/TestRangerKuduAuthorizer.java
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table_creator-internal.h
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
M src/kudu/security/simple_acl.h
18 files changed, 316 insertions(+), 216 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#24).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
12 files changed, 323 insertions(+), 163 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/24
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 24
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#16).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 291 insertions(+), 142 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/16
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 16
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 19:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063
PS15, Line 1063: 
               :       kTableName,
               :       ""
               :     },
               :     {
               :       {
> Regardless, this returns empty if get<2> is neither kTestUser nor {OWNER}.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 19
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 18:23:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#6).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 224 insertions(+), 130 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/6
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 12: Verified+1

unrelated flaky test


-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Jul 2020 18:39:39 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 6:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/16072/4//COMMIT_MSG
Commit Message:

PS4: 
> This should be further split into two parts, because it attempts to do two 
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/master/catalog_manager.cc@2954
PS4, Line 2954:     size_t found = table_name.find(req->name_filt
> Why can't you use an  unordered_map?
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc@247
PS4, Line 247:  false);
> Shouldn't these be booleans?
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc@404
PS4, Line 404:   ASSERT_OK(client_->AuthorizeAction("user", ActionPB::ALL, "db", "table", /*is_owner=*/false,
> warning: argument name 'owner' in comment does not match parameter name 'is
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc@424
PS4, Line 424:   ASSERT_OK(client_->AuthorizeAction("user", ActionPB::ALL, "db", "table", /*is_owner=*/false,
> warning: argument name 'owner' in comment does not match parameter name 'is
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc@441
PS4, Line 441:   ASSERT_OK(client_->AuthorizeAction("user", ActionPB::ALL, "db", "table", /*is_owner=*/false,
> warning: argument name 'owner' in comment does not match parameter name 'is
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h
File src/kudu/security/simple_acl.h:

http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h@27
PS4, Line 27: trol list whic
> nit: TableOwnerPair makes this sound like it should be a string, string pai
Done


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h@29
PS4, Line 29: // This is basically just a wrapper around a set<string> with a bit of parsing logic and
            : // support for the '*' wildcard.
            : class SimpleAcl {
            :  public:
            :   
> The fact that this doesn't take into account 'owner' seems wrong.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 26 Jun 2020 09:45:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#4).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
M src/kudu/security/simple_acl.h
12 files changed, 327 insertions(+), 146 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/4
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#23).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
12 files changed, 324 insertions(+), 162 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/23
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 23
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#8).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 228 insertions(+), 127 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/8
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/22/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/22/src/kudu/integration-tests/master_authz-itest.cc@779
PS22, Line 779: TestAuthzListTables
Is ListTables tested in this patch?

Also authz tokens?



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 22
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 13 Jul 2020 23:20:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#19).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 307 insertions(+), 144 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/19
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 19
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 18: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16072/18/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java:

http://gerrit.cloudera.org:8080/#/c/16072/18/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@172
PS18, Line 172: admin
nit: requiresAdmin is more clear


http://gerrit.cloudera.org:8080/#/c/16072/18/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@173
PS18, Line 173: owner
nit: isOwner is more clear



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 18
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 13:54:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 21: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@831
PS19, Line 831:   // We need to grant metadata permissions to kTestUser, otherwise alter table
              :   // would time out due to lack of privileges running IsAlterTableInProgress().
> What do you mean? OpenTable() would fail if we didn't have METADATA which w
Ah, seems I misunderstood this comment. I thought the timeout would come in the second Alter() call made by the original owner, but I think you're referring to the first call. Since there are a few alter tables in this test, would you mind clarifying the comment, e.g

"We need to grant metadata permissions to the user, otherwise the ownership change would time out due to lack of privileges when checking the alter table progress."



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 21
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 19:39:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 26 Jun 2020 13:10:38 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 24: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 24
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 15 Jul 2020 18:51:25 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#17).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 304 insertions(+), 142 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/17
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 4:

(5 comments)

Took a brief first look.

http://gerrit.cloudera.org:8080/#/c/16072/4//COMMIT_MSG
Commit Message:

PS4: 
This should be further split into two parts, because it attempts to do two distinct things:
- add a means to change owners, including the privileges required to do so
- have the Ranger subprocess check for ownership privileges


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/master/catalog_manager.cc@2954
PS4, Line 2954: unordered_set<TableOwnerPair, TableOwnerPairHash>
Why can't you use an  unordered_map?


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/ranger/ranger_client-test.cc@247
PS4, Line 247:  "notjdoe");
Shouldn't these be booleans?


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h
File src/kudu/security/simple_acl.h:

http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h@27
PS4, Line 27: TableOwnerPair
nit: TableOwnerPair makes this sound like it should be a string, string pair. Consider TableAndIsOwner or somesuch


http://gerrit.cloudera.org:8080/#/c/16072/4/src/kudu/security/simple_acl.h@29
PS4, Line 29: struct TableOwnerPairHash {
            :   int operator()(const TableOwnerPair& table_owner_pair) const {
            :     return std::hash<std::string>{}(table_owner_pair.first);
            :   }
            : };
The fact that this doesn't take into account 'owner' seems wrong.



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 25 Jun 2020 17:05:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1939
PS7, Line 1939: mismatched_table = true;
> I don't think so -- looking down at L1975, shouldn't we be authorizing as t
Ah i see, I misunderstood your point and haven't realized I changed existing behavior.



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Jul 2020 16:43:19 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 24: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 24
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 15 Jul 2020 14:41:47 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1939
PS7, Line 1939: mismatched_table = true;
> Hm isn't this out of scope for this patch and feature? Maybe it would be be
I don't think so -- looking down at L1975, shouldn't we be authorizing as the owner of the mismatched table?



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 30 Jun 2020 16:01:09 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#20).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 301 insertions(+), 150 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/20
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 20
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 19
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 16:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

PS15: 
> Can you also add a test for the case where a user gives its ownership away 
Done


http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@935
PS15, Line 935: &
> nit: capitalize and add a period
Done


http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063
PS15, Line 1063: 
               :     {
               :       {
               :         &MasterAuthzITestBase::IsAlterTableDone,
               :         &MasterAuthzITestBase::GrantGetMetadataTablePrivilege,
               :         "IsAlterTableDone",
> nit: maybe be simpler as
Unfortunately that doesn't work, kTestUser contains a hyphen which is an invalid character. Another option would be to change the value of kTestUser but I wasn't sure if I should touch it.



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 16
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 08 Jul 2020 12:17:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] [WIP] Implement owner privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: [WIP] Implement owner privileges
......................................................................


Patch Set 3:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/16072/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java:

http://gerrit.cloudera.org:8080/#/c/16072/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@113
PS3, Line 113:  .setAllowed(false)
nit: seems we typically have wrapped lines space at 4 spaces, or at an alignment point (e.g. periods, parens, etc)


http://gerrit.cloudera.org:8080/#/c/16072/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@157
PS3, Line 157:    * Creates a list of <code>RangerAccessRequest</code> for the given
             :    * <code>RangerRequestListPB</code>.
nit: update this


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/client/client.h@884
PS3, Line 884:   KuduTableCreator& set_owner(const std::string& owner);
Hrm, this seems like it belongs in the patch that introduces table ownership, or in a separate patch that only introduces the client API for setting ownership, since I imagine we'll want some tests specific to setting ownership in the client, regardless of privileges.


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/integration-tests/master_authz-itest.cc@866
PS3, Line 866: // this case doesn't make sense semantically as we don't have database
             :     // owners which would be required to create a table
What if the CreateTable statement requires ALL and delegate admin, e.g. if 'impala' is granted 'owner' privileges on some namespace of tables, and Impala creates a table within that namespace, setting the owner to someone else?


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/master/default_authz_provider.h
File src/kudu/master/default_authz_provider.h:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/master/default_authz_provider.h@51
PS3, Line 51: const std::string& /*owner*/
It seems confusing for this to have the same API as AuthorizeCreateTable(), because unlike for AuthorizeCreateTable(), this 'owner' field isn't user-specified. Rather, the only thing we care about from an authorization POV is whether or not this request was made by the owner, so maybe pass 'is_owner' as a bool instead?


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/master/ranger_authz_provider.cc
File src/kudu/master/ranger_authz_provider.cc:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/master/ranger_authz_provider.cc@106
PS3, Line 106: false, 
Shouldn't this be 'user == owner' or somesuch? Mind adding a test for this if there isn't one?


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client-test.cc@176
PS3, Line 176:   unordered_set<ActionPB, ActionHash> actions = {
             :     ActionPB::CREATE
             :   };
Why these changes?


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client-test.cc@179
PS3, Line 179: false
nit: could you annotate these with comments, e.g. "/*is_owner*/false"?


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client.h
File src/kudu/ranger/ranger_client.h:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client.h@88
PS3, Line 88: owner
nit: IMO call-sites would be clearer if this were called 'is_owner' or somesuch instead. 'owner' makes it seem like this should be a string. Same in the protobuf.



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 22 Jun 2020 19:31:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 20:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@831
PS19, Line 831:   // We need to grant metadata permissions to kTestUser, otherwise alter table
              :   // would time out due to lack of privileges running IsAlterTableInProgress().
> Alternatively, would OpenTable() fail with an authz error after transferrin
What do you mean? OpenTable() would fail if we didn't have METADATA which we need to grant so that the alter can return OK (although it would succeed even without granting METADATA to the user by name).


http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@834
PS19, Line 834: tableName
> nit: snake_case for variable names
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 20
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 19:24:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 23:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/22/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/22/src/kudu/integration-tests/master_authz-itest.cc@779
PS22, Line 779: TestAuthzListTables
> Is ListTables tested in this patch?
It does now, added grant privilege to owner to this test for ListTables and added it to TsAuthzITest.TestReadsAndWrites for authz tokens.



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 23
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jul 2020 13:59:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#11).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 264 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/11
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#12).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 265 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/12
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 19:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063
PS15, Line 1063: 
               :       kTableName,
               :       ""
               :     },
               :     {
               :       {
> Unfortunately that doesn't work, kTestUser contains a hyphen which is an in
Regardless, this returns empty if get<2> is neither kTestUser nor {OWNER}.

How about doing something like

 std::get<2>(info.param) == "{OWNER}" ? "owner" : "nonowner"

That way it's decoupled from the actual test username while still being clear what we're testing


http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@831
PS19, Line 831:   // We need to grant metadata permissions to kTestUser, otherwise alter table
              :   // would time out due to lack of privileges running IsAlterTableInProgress().
Alternatively, would OpenTable() fail with an authz error after transferring ownership?


http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@834
PS19, Line 834: tableName
nit: snake_case for variable names

Also could be const



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 19
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 18:16:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@831
PS19, Line 831:   // We need to grant metadata permissions to the user, otherwise the ownership
              :   // change would time out due to lack of privileges when checking the alter
> Ah, seems I misunderstood this comment. I thought the timeout would come in
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 22
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Jul 2020 22:16:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#22).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 305 insertions(+), 150 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/22
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 22
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 4:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/16072/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java:

http://gerrit.cloudera.org:8080/#/c/16072/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@113
PS3, Line 113:    .setAllowed(fals
> nit: seems we typically have wrapped lines space at 4 spaces, or at an alig
Done


http://gerrit.cloudera.org:8080/#/c/16072/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@157
PS3, Line 157:    *
             :    * @param requests the given RangerR
> nit: update this
Done


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/client/client.h@884
PS3, Line 884:   KuduTableCreator& set_owner(const std::string& owner);
> Hrm, this seems like it belongs in the patch that introduces table ownershi
Done


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/integration-tests/master_authz-itest.cc@866
PS3, Line 866: SERT_OK(desc.funcs.grant_privileges(this, privilege_params));
             :   ASSERT_OK(desc.funcs.do_action(this, action_params));
> What if the CreateTable statement requires ALL and delegate admin, e.g. if 
'impala' would be a trusted user, so I don't think it applies there. Regardless, owner is not a privilege, but a user owning an existing table, so to create tables with a different owner a user is required to have delegate admin + ALL on the database.


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/master/default_authz_provider.h
File src/kudu/master/default_authz_provider.h:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/master/default_authz_provider.h@51
PS3, Line 51: bool /*is_owner*/) override 
> It seems confusing for this to have the same API as AuthorizeCreateTable(),
Done


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client-test.cc@176
PS3, Line 176:   bool authorized;
             :   ASSERT_OK(client_.AuthorizeAction("jdoe", ActionPB::CREATE, "bar", "baz",
             :     
> Why these changes?
Done


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client-test.cc@179
PS3, Line 179: 
> nit: could you annotate these with comments, e.g. "/*is_owner*/false"?
Done


http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client.h
File src/kudu/ranger/ranger_client.h:

http://gerrit.cloudera.org:8080/#/c/16072/3/src/kudu/ranger/ranger_client.h@88
PS3, Line 88: is_ow
> nit: IMO call-sites would be clearer if this were called 'is_owner' or some
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 25 Jun 2020 15:15:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#7).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 229 insertions(+), 130 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/7
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Reviewed-on: http://gerrit.cloudera.org:8080/16072
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
12 files changed, 323 insertions(+), 163 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, but someone else must approve
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 25
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 8:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/authz_provider.h
File src/kudu/master/authz_provider.h:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/authz_provider.h@94
PS7, Line 94: is_owner_by
> nit: maybe call this 'is_owner_by_table_name' or something
Done


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1939
PS7, Line 1939: mismatched_table = true;
> Maybe consider populating some scoped_refptr<TableInfo> table_with_mismatch
Hm isn't this out of scope for this patch and feature? Maybe it would be better to file a JIRA and work on this separately?


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1957
PS7, Line 1957:       // if the table doesn't exist, we don't have ownership information to pass
> nit: may be obvious, but it's a little jarring to see empty strings. Maybe 
Done


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@2960
PS7, Line 2960: 
> nit: can use *user
Done


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/ranger/ranger_client-test.cc@253
PS7, Line 253:   ASSERT_TRUE(ContainsKey(tables, "default.foobar"));
             :   ASSERT_TRUE(ContainsKey(tables, "barbaz"));
             :   ASSERT_FALSE(ContainsKey(tables, "foo."));
> nit: you can use ContainsKey() from gutil/map-util.h
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 30 Jun 2020 14:42:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16072

to look at the new patch set (#18).

Change subject: KUDU-3090 Add ownership privileges
......................................................................

KUDU-3090 Add ownership privileges

Apache Ranger supports granting privileges to resource owners by using a
special "{OWNER}" username. This patch integrates Kudu's ownership model
with Ranger.

Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/master/authz_provider.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/default_authz_provider.h
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/master/ranger_authz_provider.h
M src/kudu/ranger/ranger.proto
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
11 files changed, 304 insertions(+), 142 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16072/18
-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 18
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3090 Add ownership privileges

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/authz_provider.h
File src/kudu/master/authz_provider.h:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/authz_provider.h@94
PS7, Line 94: table_names
nit: maybe call this 'is_owner_by_table_name' or something


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1939
PS7, Line 1939: mismatched_table = true;
Maybe consider populating some scoped_refptr<TableInfo> table_with_mismatched_name field that we can lock in the error case, rather than passing an empty string? I know it's super edge-casey, but it does seem like the correct behavior would be to complain about the mismatched table name rather than return an authorization error if the mismatched table is indeed owned by the user.


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1957
PS7, Line 1957:       RETURN_NOT_OK(authorize(NormalizeTableName(table_identifier.table_name()), ""));
nit: may be obvious, but it's a little jarring to see empty strings. Maybe add a comment along the lines of "If the table doesn't exist, we don't have ownership information we can pass" or somesuch.


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@2960
PS7, Line 2960: user.value()
nit: can use *user


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/ranger/ranger_client-test.cc@253
PS7, Line 253:   ASSERT_NE(tables.find("default.foobar"), tables.end());
             :   ASSERT_NE(tables.find("barbaz"), tables.end());
             :   ASSERT_EQ(tables.find("foo."), tables.end());
nit: you can use ContainsKey() from gutil/map-util.h



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 26 Jun 2020 17:31:54 +0000
Gerrit-HasComments: Yes