You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by ha...@apache.org on 2026/08/11 01:08:03 UTC

(skywalking-banyandb) 02/02: docs: record trace snapshot fallback test fix in CHANGES.md

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch fix/trace-snapshot-fallback-flake
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git

commit a69e5a2e3bde4c6beeb0e4a9ba32678196164ba1
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Tue Aug 11 01:06:36 2026 +0000

    docs: record trace snapshot fallback test fix in CHANGES.md
---
 CHANGES.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGES.md b/CHANGES.md
index beb090ba2..89e9f4282 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -92,6 +92,7 @@ Release Notes.
 
 ### Bug Fixes
 
+- Fix flaky trace snapshot-fallback tests (`TestTraceInitTSTableDeletesMultipleFailedSnapshotsOnFallback`, `TestTraceTolerantLoaderFallbackToOlderSnapshot`) that raced the async snapshot flush: they gated on the part directory, which is created at the start of the flush, so `Close()` could run before the snapshot manifest was persisted and observe zero `.snp` files. The tests now wait for the persisted `.snp` file itself, matching the measure/stream sibling tests.
 - Prevent merge-time trace sampling from dropping fragments when the same trace ID may remain in unselected parts. Provisional drops are now checked against time bounds and
   trace-ID Bloom filters in candidate outside parts whose time bounds intersect the trace's max-fragment-gap-expanded range, revalidated before publication, and retained on
   uncertainty; the default merge grace is two hours.