You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/05 07:56:10 UTC

[GitHub] [spark] HyukjinKwon edited a comment on issue #27460: [SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade, and disable CRAN

HyukjinKwon edited a comment on issue #27460: [SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade, and disable CRAN
URL: https://github.com/apache/spark/pull/27460#issuecomment-582284510
 
 
   @shaneknapp to summarize what happen so far:
   
   - Seems R version itself bumped up correctly to 3.5.2; however, seems we should reinstall the packages installed previously, including `r-base`. It caused some problems with error messages such as:
   
     ```
     * creating vignettes ... ERROR
     Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics:
     package ���htmltools��� was installed by an R version with different internals; it needs to be 
     reinstalled for use with this R version
     ```
   
     Currently, I fixed it by making tests permissive and just skipping CRAN check but we should at least reenable CRAN back. Can we reinstall the packages previously installed for R 3.5.2?
   
     Once this is done, I should reenable it [here](https://github.com/apache/spark/pull/27460/files#diff-9e63dce390dd4d80c6abe3413a8b1984R34) per SPARK-30737
   
   - Looks like Arrow R library was unable to find after the upgrade:
   
     ```
     test_sparkSQL_arrow.R:25: skip: createDataFrame/collect Arrow optimization
     arrow cannot be loaded
     ```
   
     This seems causing to skip Arrow related tests in Jenkins.
   
   - I think this is minor but seems there are some enviornment issues assuming from:
   
     ```
     test_sparkSQL.R:499: warning: SPARK-17811: can create DataFrame containing NA as date and time
     Your system is mis-configured: ���/etc/localtime��� is not a symlink
     ```
     ```
     test_sparkSQL.R:499: warning: SPARK-17811: can create DataFrame containing NA as date and time
     It is strongly recommended to set envionment variable TZ to ���America/Los_Angeles��� (or 
     equivalent)
     ```
   
     Once this is done, I should remove [this line](https://github.com/apache/spark/pull/27460/files#diff-d4011863c8b176830365b2f224a84bf2R504). But this isn't really a big deal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org