You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/09 06:03:24 UTC

[GitHub] [incubator-nuttx] Bhindhiya opened a new pull request #1736: RX65N Ethernet pre-check warnings resolved

Bhindhiya opened a new pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736


   Resolved RX65N pre-check warnings in rx65n_eth.c
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Bhindhiya commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
Bhindhiya commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691031935


   @xiaoxiang781216,
   ICMPv6 is an integral part of IPv6 and RX65N supports IPv6 whereas hashtable indexing is not supported. So, only the hashtable indexing related code is being removed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-689367243


   @Bhindhiya why rx65n_eth don't support ICMPv6?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Bhindhiya commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
Bhindhiya commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691031935






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691051506






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Bhindhiya commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
Bhindhiya commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691031935






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-692412125


   @Bhindhiya thanks for explanation. Let's merge it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Bhindhiya commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
Bhindhiya commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691996318


   @xiaoxiang781216 ,
   The multicast packet can be filtered at Ethernet level or at IP layer. 
   RX65N supports IPv6 multicast filtering only in the IP layer, not at the Ethernet level (mac layer) since RX65N hardware does not have hash mac register.
   All received multicast frames are passed to IP layer and IP layer detects whether the received packet belongs to the defined multicast group.
   IPv6 multicast has been tested on RX65N by configuring CONFIG_NET_MLD=y and working fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691051506


   > @xiaoxiang781216,
   > ICMPv6 is an integral part of IPv6 and RX65N supports IPv6 whereas hashtable indexing is not supported. So, only the hashtable indexing related code is being removed.
   
   So you don't want to support IPv6 multicast?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1736: RX65N Ethernet pre-check warnings resolved

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-691051506






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org