You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Carsten Ziegeler <cz...@sundn.de> on 2001/02/21 16:43:46 UTC
RE: cvs commit: xml-cocoon/src/org/apache/cocoon/servlet CocoonServlet.java
> Berin Loritsch wrote:
>
> Index: CocoonServlet.java
> ===================================================================
> RCS file:
> /home/cvs/xml-cocoon/src/org/apache/cocoon/servlet/Attic/CocoonSer
> vlet.java,v
>
> retrieving revision 1.1.4.61
> retrieving revision 1.1.4.62
> diff -u -r1.1.4.61 -r1.1.4.62
> --- CocoonServlet.java 2001/02/21 07:36:19 1.1.4.61
> +++ CocoonServlet.java 2001/02/21 15:16:27 1.1.4.62
> @@ -71,8 +71,8 @@
> static final long minute = 60 * second;
> static final long hour = 60 * minute;
>
> - protected long creationTime = 0;
> - protected Cocoon cocoon;
> + private long creationTime = 0;
> + private Cocoon cocoon;
> protected Exception exception;
> protected DefaultContext appContext = new DefaultContext();
>
> @@ -383,7 +393,7 @@
> /**
> * Create the environment for the request
> */
> - protected Environment getEnvironment(String uri,
> + private Environment getEnvironment(String uri,
> HttpServletRequest req,
> HttpServletResponse res)
> throws Exception {
>
>
Earlier today I changed the CocoonServlet to make subclasses possible.
The changes made some methods and instance variables protected, so that
subclasses can override and use them.
Why did you change some of them back to private?
Carsten
Re: cvs commit: xml-cocoon/src/org/apache/cocoon/servlet
CocoonServlet.java
Posted by Berin Loritsch <bl...@apache.org>.
Carsten Ziegeler wrote:
>
> > Berin Loritsch wrote:
> >
> > Index: CocoonServlet.java
> > ===================================================================
> > RCS file:
> > /home/cvs/xml-cocoon/src/org/apache/cocoon/servlet/Attic/CocoonSer
> > vlet.java,v
> >
> > retrieving revision 1.1.4.61
> > retrieving revision 1.1.4.62
> > diff -u -r1.1.4.61 -r1.1.4.62
> > --- CocoonServlet.java 2001/02/21 07:36:19 1.1.4.61
> > +++ CocoonServlet.java 2001/02/21 15:16:27 1.1.4.62
> > @@ -71,8 +71,8 @@
> > static final long minute = 60 * second;
> > static final long hour = 60 * minute;
> >
> > - protected long creationTime = 0;
> > - protected Cocoon cocoon;
> > + private long creationTime = 0;
> > + private Cocoon cocoon;
> > protected Exception exception;
> > protected DefaultContext appContext = new DefaultContext();
> >
> > @@ -383,7 +393,7 @@
> > /**
> > * Create the environment for the request
> > */
> > - protected Environment getEnvironment(String uri,
> > + private Environment getEnvironment(String uri,
> > HttpServletRequest req,
> > HttpServletResponse res)
> > throws Exception {
> >
> >
> Earlier today I changed the CocoonServlet to make subclasses possible.
> The changes made some methods and instance variables protected, so that
> subclasses can override and use them.
>
> Why did you change some of them back to private?
it was a mistake. I will fix it.
>
> Carsten
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org