You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/22 09:12:49 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1112: [CELEBORN-170][IMPROVEMENT] Extract ObservedDevice from DeviceMonitor

AngersZhuuuu opened a new pull request, #1112:
URL: https://github.com/apache/incubator-celeborn/pull/1112

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   Extract ObservedDevice from DeviceMonitor
   
   
   ### Why are the changes needed?
   Extract class
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1112: [CELEBORN-170][IMPROVEMENT] Extract ObservedDevice from DeviceMonitor

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1112:
URL: https://github.com/apache/incubator-celeborn/pull/1112#issuecomment-1362601525

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1112?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1112](https://codecov.io/gh/apache/incubator-celeborn/pull/1112?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00afd83) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/3cdc25286d422cffeb593488ca9439f872625912?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cdc252) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1112      +/-   ##
   ============================================
   - Coverage     27.17%   27.17%   -0.00%     
     Complexity      766      766              
   ============================================
     Files           195      196       +1     
     Lines         16783    16785       +2     
     Branches       1814     1811       -3     
   ============================================
     Hits           4559     4559              
   - Misses        11922    11924       +2     
     Partials        302      302              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../service/deploy/worker/storage/DeviceMonitor.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvRGV2aWNlTW9uaXRvci5zY2FsYQ==) | `6.48% <0.00%> (+2.48%)` | :arrow_up: |
   | [...service/deploy/worker/storage/ObservedDevice.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvT2JzZXJ2ZWREZXZpY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu closed pull request #1112: [CELEBORN-170][IMPROVEMENT] Extract ObservedDevice from DeviceMonitor

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu closed pull request #1112: [CELEBORN-170][IMPROVEMENT] Extract ObservedDevice from DeviceMonitor
URL: https://github.com/apache/incubator-celeborn/pull/1112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org