You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "dylanpiergies (via GitHub)" <gi...@apache.org> on 2024/06/04 00:50:31 UTC
[PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
dylanpiergies opened a new pull request, #14314:
URL: https://github.com/apache/camel/pull/14314
# Description
The implementation of CAMEL-20266 introduced an issue whereby the async client would attempt to execute the `AsyncCallback#done` method. When the consumer is a `ServiceBusConsumer`, this would cause the callback invocation to fail because it results in `Mono#block` being invoked on a Reactor thread.
Switching the `ServiceBusProducer` to synchronous operation seems to be the most straightforward way to address this issue. It is unknown whether this issue can also impact other consumers.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14314:
URL: https://github.com/apache/camel/pull/14314#issuecomment-2148076886
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14314:
URL: https://github.com/apache/camel/pull/14314#issuecomment-2147056179
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "dylanpiergies (via GitHub)" <gi...@apache.org>.
dylanpiergies commented on PR #14314:
URL: https://github.com/apache/camel/pull/14314#issuecomment-2148076287
/component-test azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #14314:
URL: https://github.com/apache/camel/pull/14314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14314:
URL: https://github.com/apache/camel/pull/14314#issuecomment-2146365214
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #14314:
URL: https://github.com/apache/camel/pull/14314#issuecomment-2147055226
/component-test azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20660: Use synchronous Azure ServiceBusSenderClient [camel]
Posted by "dylanpiergies (via GitHub)" <gi...@apache.org>.
dylanpiergies commented on PR #14314:
URL: https://github.com/apache/camel/pull/14314#issuecomment-2147238574
Looks like there's some inconsistency with source generation. Executing `./mvnw clean install -DskipTests` does not leave any uncommitted files. Trying with `./etc/scripts/regen.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org