You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by baishuo <gi...@git.apache.org> on 2014/07/24 09:02:18 UTC
[GitHub] spark pull request: Update HiveMetastoreCatalog.scala
GitHub user baishuo opened a pull request:
https://github.com/apache/spark/pull/1569
Update HiveMetastoreCatalog.scala
I think it's better to defined hiveQlTable as a val
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baishuo/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1569
----
commit a7b32a28a59886dfac45331d781a548fc18b098f
Author: baishuo(白硕) <vc...@hotmail.com>
Date: 2014-07-24T07:01:33Z
Update HiveMetastoreCatalog.scala
I think it's better to defined hiveQlTable as a val
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update HiveMetastoreCatalog.scala
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50099452
Please include [SQL] in the PR title for anything that changes Spark SQL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by baishuo <gi...@git.apache.org>.
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50180682
thank you @marmbrus , I had modify it to "@transient lazy val" and the run "sbt/sbt catalyst/test sql/test hive/test" at master branch , all test passed. if only "val", test can not passed.
the following is the tail of results of test:
[info] - Partition pruning - with filter on string partition key - query test
[info] - Partition pruning - with filter on int partition key - pruning test
[info] - Partition pruning - with filter on int partition key - query test
[info] - Partition pruning - left only 1 partition - pruning test
[info] - Partition pruning - left only 1 partition - query test
[info] - Partition pruning - all partitions pruned - pruning test
[info] - Partition pruning - all partitions pruned - query test
[info] - Partition pruning - pruning with both column key and partition key - pruning test
[info] - Partition pruning - pruning with both column key and partition key - query test
[info] HiveResolutionSuite:
[info] - table.attr
[info] - database.table
[info] - database.table table.attr
[info] - alias.attr
[info] - subquery-alias.attr
[info] - quoted alias.attr
[info] - attr
[info] - alias.star
[info] - case insensitivity with scala reflection
[info] - nested repeated resolution
[info] BigDataBenchmarkSuite:
[info] - No data files found for BigDataBenchmark tests. !!! IGNORED !!!
[info] ScalaTest
[info] Run completed in 2 minutes, 55 seconds.
[info] Total number of tests run: 150
[info] Suites: completed 14, aborted 0
[info] Tests: succeeded 150, failed 0, canceled 0, ignored 7, pending 0
[info] All tests passed.
[info] Passed: Total 150, Failed 0, Errors 0, Passed 150, Ignored 7
[success] Total time: 267 s, completed Jul 25, 2014 10:17:09 AM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50195121
QA tests have started for PR 1569. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17194/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update HiveMetastoreCatalog.scala
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50099594
QA tests have started for PR 1569. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17154/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50203064
QA results for PR 1569:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17194/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50122704
I guess it is a `def` since it is not serializable...
You could make it a `@transient lazy val`.
BTW you can run the tests locally: `sbt/sbt catalyst/test sql/test hive/test`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update HiveMetastoreCatalog.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-49974351
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50194804
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by baishuo <gi...@git.apache.org>.
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50101782
modify the title, add [SQL]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update HiveMetastoreCatalog.scala
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50099422
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SQL]Update HiveMetastoreCatalog.scala
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1569#issuecomment-50203778
Thanks, I merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---