You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/09 00:23:31 UTC

[GitHub] [helix] i3wangyi commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

i3wangyi commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …
URL: https://github.com/apache/helix/pull/369#discussion_r312251697
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/crushMapping/CardDealingAdjustmentAlgorithmV2.java
 ##########
 @@ -55,6 +74,27 @@ public CardDealingAdjustmentAlgorithmV2(Topology topology, int replica, Mode mod
     }
   }
 
+  // expose internal fields only for testing purpose
 
 Review comment:
   Refactored the subclass + protected pattern

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org