You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/29 12:37:35 UTC
[GitHub] [phoenix] stoty opened a new pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
stoty opened a new pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123
test version snapshot phoenix-thirdparty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770008879
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 2s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 10s | 4.x passed |
| +1 :green_heart: | compile | 1m 35s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 42s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 25s | 4.x passed |
| +0 :ok: | spotbugs | 4m 11s | root in 4.x has 1000 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 58s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 50s | phoenix-pherf in 4.x has 42 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 42s | phoenix-tools in 4.x has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 57s | the patch passed |
| +1 :green_heart: | compile | 1m 33s | the patch passed |
| +1 :green_heart: | javac | 1m 33s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 42s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 27s | the patch passed |
| -1 :x: | spotbugs | 3m 12s | phoenix-core generated 9 new + 936 unchanged - 9 fixed = 945 total (was 945) |
| -1 :x: | spotbugs | 1m 7s | phoenix-pherf generated 1 new + 41 unchanged - 1 fixed = 42 total (was 42) |
| -1 :x: | spotbugs | 0m 58s | phoenix-tools generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3) |
| -1 :x: | spotbugs | 4m 25s | root generated 11 new + 989 unchanged - 11 fixed = 1000 total (was 1000) |
||| _ Other Tests _ |
| -1 :x: | unit | 141m 13s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 195m 50s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] |
| | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] |
| | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] |
| | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] |
| FindBugs | module:phoenix-pherf |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] |
| FindBugs | module:phoenix-tools |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] |
| FindBugs | module:root |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] |
| | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] |
| | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] |
| | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1123 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle |
| uname | Linux cb50d0a9e513 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 31a8f59 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/new-spotbugs-root.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/testReport/ |
| Max. process+thread count | 5776 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770178661
The difference is normal. In the 4.x server jar we add the shaded packages manually, and do not relocate. (Don't know why, probably historical reasons)
In 4.x HEAD we don't add commons-cli, and use whatever HBase/Hadoop classpatch gives us.
In master HEAD we add and shade every dependecy that isn't excluded and provided
(including commons-cli), and relocate it under org/apache/phoenix/shaded .
With this (updated) patch we add the org.apache.phoenix.thirdparty.org.apache.commons.cli classes on either branch.
I've just run a test locally on the Phoenix 5 pseudodistributed cluster with this patch, and didn't get any errors.
I am quite baffled why the same setup would cause problems on 4.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770199458
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 8s | 4.x passed |
| +1 :green_heart: | compile | 1m 32s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 40s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 26s | 4.x passed |
| +0 :ok: | spotbugs | 4m 13s | root in 4.x has 1000 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 59s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 50s | phoenix-pherf in 4.x has 42 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 45s | phoenix-tools in 4.x has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 54s | the patch passed |
| +1 :green_heart: | compile | 1m 32s | the patch passed |
| +1 :green_heart: | javac | 1m 32s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 43s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 24s | the patch passed |
| -1 :x: | spotbugs | 3m 11s | phoenix-core generated 9 new + 936 unchanged - 9 fixed = 945 total (was 945) |
| -1 :x: | spotbugs | 1m 7s | phoenix-pherf generated 1 new + 41 unchanged - 1 fixed = 42 total (was 42) |
| -1 :x: | spotbugs | 0m 59s | phoenix-tools generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3) |
| -1 :x: | spotbugs | 4m 24s | root generated 11 new + 989 unchanged - 11 fixed = 1000 total (was 1000) |
||| _ Other Tests _ |
| -1 :x: | unit | 209m 8s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 264m 7s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] |
| | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] |
| | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] |
| | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] |
| FindBugs | module:phoenix-pherf |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] |
| FindBugs | module:phoenix-tools |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] |
| FindBugs | module:root |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] |
| | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] |
| | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] |
| | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1123 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle |
| uname | Linux 52732d13a86d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 31a8f59 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/new-spotbugs-root.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/testReport/ |
| Max. process+thread count | 5891 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770178977
I found the problem.
I've forgotten to add the fixed phoenix-server pom.xml to the amended commit.
At least now I've run and end-to-end test on 5.x
Can you try yet again on 4.x with the now-really-fixed-i-swear patch @yanxinyi ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770172946
Huh, I'm getting the same error.
When I compared the 4.x and master server jars, the master branch server jar does have `META-INF/maven/commons-cli/` but not 4.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-769797164
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 46s | 4.x passed |
| +1 :green_heart: | compile | 1m 32s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 42s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 25s | 4.x passed |
| +0 :ok: | spotbugs | 4m 12s | root in 4.x has 1000 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 47s | phoenix-pherf in 4.x has 42 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 44s | phoenix-tools in 4.x has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 21s | root in the patch failed. |
| -1 :x: | compile | 0m 18s | root in the patch failed. |
| -1 :x: | javac | 0m 18s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 9s | The patch fails to run checkstyle in root |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 21s | root in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix-core in the patch failed. |
| -1 :x: | javadoc | 0m 8s | phoenix-pherf in the patch failed. |
| -1 :x: | javadoc | 0m 7s | phoenix-tools in the patch failed. |
| -1 :x: | spotbugs | 0m 41s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix-core in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix-pherf in the patch failed. |
| -1 :x: | spotbugs | 0m 7s | phoenix-tools in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 20s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 35m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1123 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle |
| uname | Linux a63d834c6ebe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 31a8f59 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-core.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-pherf.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-tools.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-pherf.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-tools.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/testReport/ |
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: . phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770234563
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 55s | 4.x passed |
| +1 :green_heart: | compile | 1m 29s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 43s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 34s | 4.x passed |
| +0 :ok: | spotbugs | 4m 12s | root in 4.x has 1000 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 57s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 49s | phoenix-pherf in 4.x has 42 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 42s | phoenix-tools in 4.x has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 34s | the patch passed |
| +1 :green_heart: | javac | 1m 34s | the patch passed |
| -1 :x: | checkstyle | 1m 42s | root: The patch generated 28 new + 2743 unchanged - 28 fixed = 2771 total (was 2771) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 34s | the patch passed |
| -1 :x: | spotbugs | 3m 12s | phoenix-core generated 9 new + 936 unchanged - 9 fixed = 945 total (was 945) |
| -1 :x: | spotbugs | 1m 5s | phoenix-pherf generated 1 new + 41 unchanged - 1 fixed = 42 total (was 42) |
| -1 :x: | spotbugs | 0m 57s | phoenix-tools generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3) |
| -1 :x: | spotbugs | 4m 27s | root generated 11 new + 989 unchanged - 11 fixed = 1000 total (was 1000) |
||| _ Other Tests _ |
| -1 :x: | unit | 209m 28s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 47s | The patch does not generate ASF License warnings. |
| | | 264m 22s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] |
| | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] |
| | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] |
| | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] |
| FindBugs | module:phoenix-pherf |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] |
| FindBugs | module:phoenix-tools |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] |
| FindBugs | module:root |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] |
| | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] |
| | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] |
| | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1123 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle |
| uname | Linux ac48a4eb3666 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 31a8f59 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-root.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/testReport/ |
| Max. process+thread count | 5708 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-server phoenix-tools . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770171122
No I didn't test it, I didn't have the time set up a 4.x pseudo-distributed cluster yesterday.
I just keep forgetting that you need to add everything to the 4.x server jar manually
(as opposed to 5.x, where we add everything not explcitly excluded, or set as provided)
Can you re-test with the updated patch @yanxinyi ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi edited a comment on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
yanxinyi edited a comment on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770172946
Huh, I'm getting the same error.
When I compared the 4.x and master server jars, the master branch server jar does have dependent classes but not 4.x.
Here is the list
org/apache/phoenix/shaded/org/apache/commons/cli/
org/apache/phoenix/shaded/org/apache/commons/cli/GnuParser.class
org/apache/phoenix/shaded/org/apache/commons/cli/HelpFormatter$1.class
org/apache/phoenix/shaded/org/apache/commons/cli/MissingArgumentException.class
org/apache/phoenix/shaded/org/apache/commons/cli/Option$Builder.class
org/apache/phoenix/shaded/org/apache/commons/cli/Options.class
org/apache/phoenix/shaded/org/apache/commons/cli/PatternOptionBuilder.class
org/apache/phoenix/shaded/org/apache/commons/cli/Util.class
org/apache/phoenix/shaded/org/apache/commons/cli/BasicParser.class
org/apache/phoenix/shaded/org/apache/commons/cli/CommandLineParser.class
org/apache/phoenix/shaded/org/apache/commons/cli/HelpFormatter.class
org/apache/phoenix/shaded/org/apache/commons/cli/OptionGroup.class
org/apache/phoenix/shaded/org/apache/commons/cli/Parser.class
org/apache/phoenix/shaded/org/apache/commons/cli/UnrecognizedOptionException.class
org/apache/phoenix/shaded/org/apache/commons/cli/AlreadySelectedException.class
org/apache/phoenix/shaded/org/apache/commons/cli/CommandLine$Builder.class
org/apache/phoenix/shaded/org/apache/commons/cli/CommandLine.class
org/apache/phoenix/shaded/org/apache/commons/cli/HelpFormatter$OptionComparator.class
org/apache/phoenix/shaded/org/apache/commons/cli/Option$1.class
org/apache/phoenix/shaded/org/apache/commons/cli/OptionValidator.class
org/apache/phoenix/shaded/org/apache/commons/cli/PosixParser.class
META-INF/maven/commons-cli/
META-INF/maven/commons-cli/commons-cli/
META-INF/maven/commons-cli/commons-cli/pom.xml
org/apache/phoenix/shaded/org/apache/commons/cli/AmbiguousOptionException.class
org/apache/phoenix/shaded/org/apache/commons/cli/DefaultParser.class
org/apache/phoenix/shaded/org/apache/commons/cli/MissingOptionException.class
org/apache/phoenix/shaded/org/apache/commons/cli/Option.class
org/apache/phoenix/shaded/org/apache/commons/cli/OptionBuilder.class
org/apache/phoenix/shaded/org/apache/commons/cli/ParseException.class
org/apache/phoenix/shaded/org/apache/commons/cli/TypeHandler.class
META-INF/maven/commons-cli/commons-cli/pom.properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770167422
Huh, I'm not sure if this is my local setting issue or something else.
With my local HBase setup, I tried 4.14.3 and 4.15 server jars without any issues when I called `./hbase org.apache.phoenix.mapreduce.index.IndexTool`, which is using the phoenix server jar as the classpath. However, I applied your patch and built the 4.x branch locally. Here are my stack trace and error
./hbase org.apache.phoenix.mapreduce.index.IndexTool
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/phoenix/thirdparty/org/apache/commons/cli/ParseException
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
at java.lang.Class.privateGetMethodRecursive(Class.java:3048)
at java.lang.Class.getMethod0(Class.java:3018)
at java.lang.Class.getMethod(Class.java:1784)
at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:650)
at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:632)
Caused by: java.lang.ClassNotFoundException: org.apache.phoenix.thirdparty.org.apache.commons.cli.ParseException
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 7 more
@stoty did you verify it locally? I guess the ITs are not using the server patch so it's very hard to catch the issue...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770179408
Sure @stoty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1123: PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770178977
I found the problem.
I've forgot to add the fixed phoenix-server pom.xml to the amended commit.
At least now I've run and end-to-end test on 5.x
Can you try yet again on 4.x with the now-really-fixed-i-swear patch @yanxinyi ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org