You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/26 09:12:28 UTC

[GitHub] [airflow] jeffolsi opened a new issue #8565: SalesforceHook missing method to return dataframe

jeffolsi opened a new issue #8565:
URL: https://github.com/apache/airflow/issues/8565


   Currently SalesforceHook has function `write_object_to_file` which query salesforce and save the output to file. On the way it also uses df. The function even return the df.
   the problem is that if someone wants only df he must also provide `file_name` **which can't be empty!** and set `fmt=None` this doesn't really work well and it causes troubles.
   
   The function `write_object_to_file` should be divided to `object_to_df` which returns df and then the `write_object_to_file` can uses `object_to_df` as the first step before exporting to file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pranjalmittal commented on issue #8565: SalesforceHook missing method to return dataframe

Posted by GitBox <gi...@apache.org>.
pranjalmittal commented on issue #8565:
URL: https://github.com/apache/airflow/issues/8565#issuecomment-621830739


   Created a PR for the issue: https://github.com/apache/airflow/pull/8644


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jeffolsi commented on issue #8565: SalesforceHook missing method to return dataframe

Posted by GitBox <gi...@apache.org>.
jeffolsi commented on issue #8565:
URL: https://github.com/apache/airflow/issues/8565#issuecomment-630114204


   fixed in https://github.com/apache/airflow/pull/8644


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jeffolsi commented on issue #8565: SalesforceHook missing method to return dataframe

Posted by GitBox <gi...@apache.org>.
jeffolsi commented on issue #8565:
URL: https://github.com/apache/airflow/issues/8565#issuecomment-620432713


   @VinodKumarLogan sure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jeffolsi closed issue #8565: SalesforceHook missing method to return dataframe

Posted by GitBox <gi...@apache.org>.
jeffolsi closed issue #8565:
URL: https://github.com/apache/airflow/issues/8565


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] VinodKumarLogan commented on issue #8565: SalesforceHook missing method to return dataframe

Posted by GitBox <gi...@apache.org>.
VinodKumarLogan commented on issue #8565:
URL: https://github.com/apache/airflow/issues/8565#issuecomment-620396479


   Hi @jeffolsi @potiuk , can I give this a shot and submit a PR? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org