[jira] Commented: (THRIFT-851) php extension fails to compile on centos 5.x

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898721#action_12898721 ] 

Todd Lipcon commented on THRIFT-851:
------------------------------------

Rather than doing the ifdef, can we just include sys/param.h? It seems like this exists on both OSX and Linux and includes the correct endianness file. Also will need to add this header to configure.ac in the AC_CHECK_HEADER section.

byte_order.h doesn't seem to be necessary, since we already define our own byteswap macro, right?

> php extension fails to compile on centos 5.x
> --------------------------------------------
>
>                 Key: THRIFT-851
>                 URL: https://issues.apache.org/jira/browse/THRIFT-851
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (PHP)
>    Affects Versions: 0.4
>            Reporter: Anthony Molinaro
>         Attachments: php-ext-include.patch
>
>
> At some point the includes for endian.h and byte_order.h were changed from
> #include <endian.h>
> #include <byteswap.h>
> to
> #include <machine/endian.h>
> #include <machine/byte_order.h>
> Unfortunately the latter files only exist on bsd and bsd derived systems like Mac OSX.
> I fixed it by using some ifdef's and using the old includes on linux.
> Patch is attached

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.