You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by "bmahler (via GitHub)" <gi...@apache.org> on 2024/03/13 22:10:36 UTC
[PR] [mesos-tidy] Fix broken Dockerfile due to llvm repo move. [mesos]
bmahler opened a new pull request, #516:
URL: https://github.com/apache/mesos/pull/516
This appears to fix the mesos-tidy docker image build, which now works per the readme instructions:
```
$ docker build -t mesos-tidy .
```
Running the image was hitting gcc internal errors due to OOMs, which I fixed via the updates shown in the readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [mesos-tidy] Fix broken Dockerfile due to llvm repo move. [mesos]
Posted by "bbannier (via GitHub)" <gi...@apache.org>.
bbannier commented on code in PR #516:
URL: https://github.com/apache/mesos/pull/516#discussion_r1524323208
##########
support/mesos-tidy/Dockerfile:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM ubuntu:xenial
+FROM --platform=linux/amd64 ubuntu:xenial
Review Comment:
Hardcoding the platform is inconsistent with how you now document `docker run`; consistent would be to drop the modification here and instead document in the readme `docker build --platform=linux/amd64 ...`.
That said, such a setup would still only work if the host is actually `amd64` (and e.g., fail on arm setups like newer macs unless the Docker VM emulates `amd64` and does not use the default `arm64` architecture). I wonder whether we shouldn't just get rid of all the hardcoded and documented platform code here completely; the `ubuntu:xenial` image we use is already multi-platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [mesos-tidy] Fix broken Dockerfile due to llvm repo move. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler closed pull request #516: [mesos-tidy] Fix broken Dockerfile due to llvm repo move.
URL: https://github.com/apache/mesos/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [mesos-tidy] Fix broken Dockerfile due to llvm repo move. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on PR #516:
URL: https://github.com/apache/mesos/pull/516#issuecomment-1998292375
Attempting to re-open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [mesos-tidy] Fix broken Dockerfile due to llvm repo move. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on code in PR #516:
URL: https://github.com/apache/mesos/pull/516#discussion_r1525357888
##########
support/mesos-tidy/Dockerfile:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM ubuntu:xenial
+FROM --platform=linux/amd64 ubuntu:xenial
Review Comment:
> consistent would be to drop the modification here and instead document in the readme docker build --platform=linux/amd64
ah yeah true, good point, I could move the platform to the build command itself rather than burn it into the Dockerfile
> such a setup would still only work if the host is actually amd64 (and e.g., fail on arm setups like newer macs unless the Docker VM emulates amd64 and does not use the default arm64 architecture
hm.. I am on an M1 mac, and encountered the following error that prompted me to add the platform which fixed the error:
https://stackoverflow.com/questions/71040681/qemu-x86-64-could-not-open-lib64-ld-linux-x86-64-so-2-no-such-file-or-direc
Then when running I would get the following, which prompted me to add the `--platform` arg on the run command as well:
```
The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
```
By the way, are you able to add me as a collaborator on the mesos organization in Docker hub? I don't seem to have access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [mesos-tidy] Fix broken Dockerfile due to llvm repo move. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on PR #516:
URL: https://github.com/apache/mesos/pull/516#issuecomment-1998291852
@bbannier sorry, accidentally got this closed this when updating the branch, where I deleted then pushed instead of force pushing, and it doesn't seem like I can re-open this one. Here's the new one: https://github.com/apache/mesos/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org