You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/24 16:34:20 UTC
[GitHub] [pulsar] merlimat opened a new pull request #10351: Resource locks should automatically revalidate after a metadata session is re-established
merlimat opened a new pull request #10351:
URL: https://github.com/apache/pulsar/pull/10351
### Motivation
This change is to enhance the `ResourceLock` to automatically revalidate the lock with the metadata store once a session is lost and then re-established.
There are multiple state in which a lock can be left after the session is recovered, with either stale value that is going to get cleaned up or some other instance took over the lock.
This single implementation will be then used in all the places where we're taking ownerships in the code-base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #10351: Resource locks should automatically revalidate after a metadata session is re-established
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10351:
URL: https://github.com/apache/pulsar/pull/10351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10351: Resource locks should automatically revalidate after a metadata session is re-established
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10351:
URL: https://github.com/apache/pulsar/pull/10351#issuecomment-826251721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10351: Resource locks should automatically revalidate after a metadata session is re-established
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10351:
URL: https://github.com/apache/pulsar/pull/10351#issuecomment-826251721
"CI - Unit - Brokers - Other / unit-tests" build job hangs because of separate issue #10356 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10351: Resource locks should automatically revalidate after a metadata session is re-established
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10351:
URL: https://github.com/apache/pulsar/pull/10351#issuecomment-826349627
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10351: Resource locks should automatically revalidate after a metadata session is re-established
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10351:
URL: https://github.com/apache/pulsar/pull/10351#issuecomment-901606140
The test LockManagerTest.revalidateLockOnDifferentSession added by this PR is flaky. @merlimat would you mind taking a look at the stacktraces provided in the issue about the flaky test, #11690 ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org