[GitHub] [airflow] potiuk commented on issue #15685: Undefined `conf` when using AWS secrets manager backend and `sql_alchemy_conn_secret`

[GitBox <gi...@apache.org>]

potiuk commented on issue #15685:
URL: https://github.com/apache/airflow/issues/15685#issuecomment-834181697


   Yeah. We do have a problem with 'conf' causing circular references (not regular circular imports, just references because we have circular dependencies between modules in our code which IMHO should be unentangled and make the dependencies straightforward. It's pretty deeply embedded in the way how configuration is done and the fact that we 'plug-in' the code (like secret backends) to conf which then through chain of dependencies goes back and requires conf (but there are other, similar places with conf being in the middle of circular dependencies).
   
   We have some hacks in the code I solved already quite a few of those in the past (for example here: https://github.com/apache/airflow/pull/13260), but it was more of the band-aid rather than final solution. 
   
   Happy to brainstorm virtually and make some attempt to do it @uranusjr if you would like to (but likely something that we can attempt after 2.1 is released). That might also help in finally getting rid of the last pylint_todo.txt entries - which are there mainly because of the conf becoming the reason for circular dependencies (just to be clear - those are circular dependencies, not imports, those are pretty different problems). 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org