You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "315157973 (via GitHub)" <gi...@apache.org> on 2023/06/29 12:48:24 UTC

[GitHub] [pulsar] 315157973 commented on a diff in pull request #20686: [fix][test] Remove timeout for `deleteTopicCloseTransactionBufferTest`

315157973 commented on code in PR #20686:
URL: https://github.com/apache/pulsar/pull/20686#discussion_r1246574932


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferCloseTest.java:
##########
@@ -61,7 +61,7 @@ public Object[][] isPartition() {
         };
     }
 
-    @Test(timeOut = 10_000, dataProvider = "isPartition")
+    @Test(dataProvider = "isPartition")

Review Comment:
   Will it get stuck forever? Perhaps setting a timeout of 30 seconds would be safer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org