You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/07/30 22:17:58 UTC

[GitHub] [parquet-mr] sv3ndk opened a new pull request #919: PARQUET-2070 replace depracated syntax in ProtoWriteSupport.java

sv3ndk opened a new pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919


   
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET-2070)
   
   ### Tests
   
   - [ ] My PR does not need testing for this extremely good reason: I'm simply removing a private method, no feature has changes, existing unit are sufficient to validate the change.
   
   ### Commits
   
   This minor PR:
   
   * removes usage of the deprecated syntax `TextFormat.printToString(asProto)` the now recommended simple `.toString()` 
   * the private method where this code was present was only invoked from one place, where the protobuf Descriptor was already available => I moved the logic there, which removes one reflection invocation and makes the code slightly more concise (and probably trivially faster as well)
   * I also added a mention of protobuf in the readme, since Thrif and Avro were mentioned already
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sv3ndk commented on pull request #919: PARQUET-2070 replace deprecated syntax in ProtoWriteSupport.java

Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919#issuecomment-890330791


   The travis build does not seem to start, is there something I can do to trigger it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky merged pull request #919: PARQUET-2070 replace deprecated syntax in ProtoWriteSupport.java

Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #919: PARQUET-2070 replace deprecated syntax in ProtoWriteSupport.java

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919#issuecomment-892415314


   @sv3ndk, we have similar failures in Travis for other PRs as well. (Created INFRA-22171 about this issue.) Travis test is there to cover arm64 architecture. I don't think this change would hurt arm64 compatibility so I'm pushing this one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sv3ndk commented on pull request #919: PARQUET-2070 replace deprecated syntax in ProtoWriteSupport.java

Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919#issuecomment-892428149


   Makes sense, thanks for the merge @gszadovszky


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sv3ndk commented on pull request #919: PARQUET-2070 replace deprecated syntax in ProtoWriteSupport.java

Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919#issuecomment-892010193


   The unit test executed by Github seem OK, but the Travis build has failed with no logs after being queued for about 6h.
   Would we be facing a timeout on Travis side due to lack of resource? 
   What's a good way to address this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org