You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/11 09:39:03 UTC
[GitHub] [netbeans] emilianbold opened a new pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
emilianbold opened a new pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#issuecomment-726884988
So I tested it. 2 things here:
* the matched folders should also highlighted, like the characters from the file name
* There is no action on the checkbox. Nothing happens when I check/uncheck it. I expect that the search will triggered again. This happens, when you check/uncheck the Case Sensitive checkbox.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#issuecomment-726885895
The highlighting is essential for the user to see what is highlighted from the search.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#issuecomment-727563898
Thx, I checked it and it is working great :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on a change in pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on a change in pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#discussion_r521512054
##########
File path: ide/jumpto/src/org/netbeans/modules/jumpto/file/FileSearchAction.java
##########
@@ -220,6 +220,7 @@ public boolean setListModel(final FileSearchPanel panel, String text ) {
itemsComparator.setUsePreferred(panel.isPreferedProject());
itemsComparator.setText(text);
filterFactory.setLineNumber(lineNr);
+ //TODO: EMI: searchByFolder?
Review comment:
Does this mean anything? If not, please remove, otherwise it will be hard later to figure out again what that means :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#issuecomment-725549226
Didn't test the patch yet, will do it later this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2532: [NETBEANS-5010] Go to File search based on folder path too (bz #222697)
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2532: [NETBEANS-5010] Go to File search based on folder path too (bz #222697)
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#issuecomment-731771411
All good, let's merge this one in!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on pull request #2532: Go to File search based on folder path too (bz #222697, NETBEANS-5010)
Posted by GitBox <gi...@apache.org>.
emilianbold commented on pull request #2532:
URL: https://github.com/apache/netbeans/pull/2532#issuecomment-727280177
Perhaps you'll find this more acceptable...
--emi
On Fri, Nov 13, 2020 at 7:14 PM Chrizzly <no...@github.com> wrote:
> The highlighting is essential for the user to see what is highlighted from
> the search.
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/netbeans/pull/2532#issuecomment-726885895>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHSCQQGGJLCCXNC7M5ND4TSPVSOXANCNFSM4TRYQDIQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists