You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/02/06 12:10:57 UTC
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22457
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
The test uses r'host=(\S+:[0-9]*)' to match the hosts of all the
fragment instances in query profile, i.e.
host_list = re.findall(r'host=(\S+:[0-9]*)', result.runtime_profile)
This is able to find the instance name in lines like
Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):
and get "name:27002" from it.
However, the runtime profile we get right after fetching the query
result and before closing the query might have a section of total time
after the fragment instance host, e.g.
Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):(Total: 19.999ms, non-child: 0.000ns, % non-child: 0.00%)
The regex pattern will match "name:27002):Total:" in the string. If not
all the instances have this "Total" section, the instance names mismatch
and the test will fail. See the query profile attached in the JIRA as an
example. Not sure how this happens. Maybe it's not guaranteed that the
profile is ready immediately when the last result row is fetched. There
might be a delay for the coordinator to process the final update of the
profile from executors. I think it's ok to fix the test first.
This fixes the regex pattern to be r'\(host=([^:]+:[0-9]*)\)' so it can
exactly match the instance name.
Tests
- Verified the fix locally
Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
---
M tests/query_test/test_scanners.py
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/22457/1
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22457
to look at the new patch set (#2).
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
The test uses r'host=(\S+:[0-9]*)' to match the hosts of all the
fragment instances in query profile, i.e.
host_list = re.findall(r'host=(\S+:[0-9]*)', result.runtime_profile)
This is able to find the instance name in lines like
Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):
and get "name:27002" from it.
However, the runtime profile we get right after fetching the query
result and before closing the query might have a section of total time
after the fragment instance host, e.g.
Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):(Total: 19.999ms, non-child: 0.000ns, % non-child: 0.00%)
The regex pattern will match "name:27002):Total:" in the string. If not
all the instances have this "Total" section, the instance names mismatch
and the test will fail. See the query profile attached in the JIRA as an
example. Not sure how this happens. Maybe it's not guaranteed that the
profile is ready immediately when the last result row is fetched. There
might be a delay for the coordinator to process the final update of the
profile from executors. I think it's ok to fix the test first.
This fixes the regex pattern to be r'\(host=([^:]+:[0-9]*)\)' so it can
exactly match the instance name.
Tests
- Verified the fix locally
Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
---
M tests/query_test/test_scanners.py
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/22457/2
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18231/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Feb 2025 00:39:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/18206/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 12:37:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG@24
PS2, Line 24: Not sure how this happens. Maybe it's not guaranteed that the
: profile is ready immediately when the last result row is fetched. There
: might be a delay for the coordinator to process the final update of the
: profile from executors.
It would be nice to have a reliable way to get the runtime profile.
One issue is the one mentioned in https://github.com/cloudera/impyla/pull/528 - before we close the query, the profile is not final, but if we get it after the query is closed, then the profile may be already discarded.
There may be other issues, e.g. I don't know if the coordinator waits for a final profile update from executors before closing the query.
A way to solve the before/after close dilemma would be to allow optionally to get the profile in CloseImpalaOperation(), where we can guarantee that the final profile is returned.
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Feb 2025 10:36:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11431/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 07:49:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 07:49:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 13:13:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 1:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22457/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:
http://gerrit.cloudera.org:8080/#/c/22457/1/tests/query_test/test_scanners.py@904
PS1, Line 904: ,
flake8: E231 missing whitespace after ','
http://gerrit.cloudera.org:8080/#/c/22457/1/tests/query_test/test_scanners.py@905
PS1, Line 905: +
flake8: W504 line break after binary operator
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 17:31:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22457/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:
http://gerrit.cloudera.org:8080/#/c/22457/1/tests/query_test/test_scanners.py@904
PS1, Line 904: ,
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/22457/1/tests/query_test/test_scanners.py@905
PS1, Line 905:
> flake8: W504 line break after binary operator
Done
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Feb 2025 01:14:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG@24
PS2, Line 24: Not sure how this happens. Maybe it's not guaranteed that the
: profile is ready immediately when the last result row is fetched. There
: might be a delay for the coordinator to process the final update of the
: profile from executors.
> It would be nice to have a reliable way to get the runtime profile.
Filed IMPALA-13745 for this.
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 07:49:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
The test uses r'host=(\S+:[0-9]*)' to match the hosts of all the
fragment instances in query profile, i.e.
host_list = re.findall(r'host=(\S+:[0-9]*)', result.runtime_profile)
This is able to find the instance name in lines like
Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):
and get "name:27002" from it.
However, the runtime profile we get right after fetching the query
result and before closing the query might have a section of total time
after the fragment instance host, e.g.
Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):(Total: 19.999ms, non-child: 0.000ns, % non-child: 0.00%)
The regex pattern will match "name:27002):Total:" in the string. If not
all the instances have this "Total" section, the instance names mismatch
and the test will fail. See the query profile attached in the JIRA as an
example. Not sure how this happens. Maybe it's not guaranteed that the
profile is ready immediately when the last result row is fetched. There
might be a delay for the coordinator to process the final update of the
profile from executors. I think it's ok to fix the test first.
This fixes the regex pattern to be r'\(host=([^:]+:[0-9]*)\)' so it can
exactly match the instance name.
Tests
- Verified the fix locally
Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Reviewed-on: http://gerrit.cloudera.org:8080/22457
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG@24
PS2, Line 24: Not sure how this happens. Maybe it's not guaranteed that the
: profile is ready immediately when the last result row is fetched. There
: might be a delay for the coordinator to process the final update of the
: profile from executors.
> Filed IMPALA-13745 for this.
This patch should do it:
https://gerrit.cloudera.org/c/22362/7/tests/common/impala_connection.py#165
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 18:04:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13727: Fix wrong regex for hostname in test multiple blocks mt dop
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 18:08:42 +0000
Gerrit-HasComments: No