You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2008/09/04 17:58:44 UTC
[jira] Created: (ZOOKEEPER-135) Fat jar build target
Fat jar build target
--------------------
Key: ZOOKEEPER-135
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
Project: Zookeeper
Issue Type: New Feature
Components: build
Reporter: Benjamin Reed
Priority: Minor
For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661411#action_12661411 ]
Benjamin Reed commented on ZOOKEEPER-135:
-----------------------------------------
Isn't there a way to make a dependency from the fatjar build.xml?
running "ant packages" from the top level fails because the test classes aren't built.
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-135:
------------------------------------
Attachment: ZOOKEEPER-135.patch
Fixed patch to be relative to source dir
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Priority: Minor
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-135:
-----------------------------------
Fix Version/s: 3.1.0
ben let's try to get an updated patch into 3.1?
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-135:
------------------------------------
Attachment: ZOOKEEPER-135.patch
This patch modifies the build file to create an optional fat-jar target. This target will only be build if explicitly requested. The fat-jar will have everything in it. The MainClass is a simple redirector that uses a mainClasses file to execute the main() methods of other classes.
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Priority: Minor
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-135:
-----------------------------------
Attachment: ZOOKEEPER-135.patch
added missing changed file to diff
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-135:
-----------------------------------
Attachment: ZOOKEEPER-135.patch
This updated patch now builds either from trunk/build.xml (as part of package/tar targets) or from w/in the contrib directory build.xml itself.
I basically:
1) fixed the build
2) added missing apache license header(s)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-135:
------------------------------------
Attachment: ZOOKEEPER-135.patch
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-135) Fat jar build target
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-135:
---------------------------------------
Assignee: Benjamin Reed
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Minor
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-135) Fat jar build target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663308#action_12663308 ]
Hudson commented on ZOOKEEPER-135:
----------------------------------
Integrated in ZooKeeper-trunk #194 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/194/])
. Fat jar build target. (phunt and breed via mahadev)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-135:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks pat and ben!
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661637#action_12661637 ]
Patrick Hunt commented on ZOOKEEPER-135:
----------------------------------------
give it a try now, I missed a file when creating the patch (build.xml)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-135:
-----------------------------------
Status: Open (was: Patch Available)
-1 on current patch. I really don't like putting "mainClasses" into conf and FatJar.java into the main src dir. It won't be clear to users what these files are and how/if they are related.
I do think that having this as a contrib would be fine though:
contrib/fatjar/...
contrib/fatjar/conf
contrib/fatjar/src/java/main/org/apache/...
which can contain your build.xml, mainClasses, farjar.java, etc... and esp a README.txt that describes what this is and how to use it.
I'd suggest changing the name too.
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Minor
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-135:
------------------------------------
Attachment: (was: ZOOKEEPER-135.patch)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Priority: Minor
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed reassigned ZOOKEEPER-135:
---------------------------------------
Assignee: Patrick Hunt (was: Benjamin Reed)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-135:
-----------------------------------
Status: Patch Available (was: Open)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-135) Fat jar build target
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631610#action_12631610 ]
Patrick Hunt commented on ZOOKEEPER-135:
----------------------------------------
Forgot to mention - please remove @author tags from javadoc.
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Minor
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-135:
------------------------------------
Attachment: ZOOKEEPER-135.patch
This patch makes the changes requested. I cannot figure out how to make the build.xml work though...
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-135) Fat jar build target
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-135:
------------------------------------
Status: Patch Available (was: Open)
> Fat jar build target
> --------------------
>
> Key: ZOOKEEPER-135
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Reporter: Benjamin Reed
> Priority: Minor
> Attachments: ZOOKEEPER-135.patch
>
>
> For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.