You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Raphael Kirchner (JIRA)" <ji...@apache.org> on 2008/09/01 16:16:25 UTC

[jira] Created: (WW-2795) NoParameters blocks action tag params instead of request params

NoParameters blocks action tag params instead of request params
---------------------------------------------------------------

                 Key: WW-2795
                 URL: https://issues.apache.org/struts/browse/WW-2795
             Project: Struts 2
          Issue Type: Bug
          Components: Core Interceptors
    Affects Versions: 2.1.2
            Reporter: Raphael Kirchner
            Priority: Minor


According to JavaDoc, org.apache.struts2.interceptor.NoParameters should be "should be implemented by actions that do not want any parameters set on them automatically. This may be useful if one is using the action tag and want to supply the parameters to the action manually using the param tag."

Actually something like the opposite happens: The action tag param gets blocked and the request param is used instead

Example:

		<@s.action name="Foo" executeResult="true" ignoreContextParams="true" >
			<@s.param name="input">embedded</@>
		</...@s.action>

With Foo implementing NoParams,
   1) Foo.action results in Foo.input == NULL
   2) Foo.action?input=test results in Foo.input == "test"
Where it should be "embedded" in both cases.

		<@s.action name="Foo" executeResult="true" ignoreContextParams="true" >
		</...@s.action>

With Foo implementing NoParams,
   1) Foo.action results in Foo.input == NULL
   2) Foo.action?input?test results in Foo.input == "test"
Where it should be NULL in both cases,


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-2795) NoParameters blocks action tag params instead of request params

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2795:
-----------------------------

    Fix Version/s: 2.1.3

> NoParameters blocks action tag params instead of request params
> ---------------------------------------------------------------
>
>                 Key: WW-2795
>                 URL: https://issues.apache.org/struts/browse/WW-2795
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.2
>            Reporter: Raphael Kirchner
>            Priority: Minor
>             Fix For: 2.1.3
>
>
> According to JavaDoc, org.apache.struts2.interceptor.NoParameters should be "should be implemented by actions that do not want any parameters set on them automatically. This may be useful if one is using the action tag and want to supply the parameters to the action manually using the param tag."
> Actually something like the opposite happens: The action tag param gets blocked and the request param is used instead
> Example:
> 		<@s.action name="Foo" executeResult="true" ignoreContextParams="true" >
> 			<@s.param name="input">embedded</@>
> 		</...@s.action>
> With Foo implementing NoParams,
>    1) Foo.action results in Foo.input == NULL
>    2) Foo.action?input=test results in Foo.input == "test"
> Where it should be "embedded" in both cases.
> 		<@s.action name="Foo" executeResult="true" ignoreContextParams="true" >
> 		</...@s.action>
> With Foo implementing NoParams,
>    1) Foo.action results in Foo.input == NULL
>    2) Foo.action?input?test results in Foo.input == "test"
> Where it should be NULL in both cases,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WW-2795) NoParameters blocks action tag params instead of request params

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Musachy Barroso resolved WW-2795.
---------------------------------

    Resolution: Not A Problem

@NoParameters is ignored by the "action" tag, the parameters that it prevents, are the one set by the params interceptor (request parameters). I will update the javadoc to reflect this.

> NoParameters blocks action tag params instead of request params
> ---------------------------------------------------------------
>
>                 Key: WW-2795
>                 URL: https://issues.apache.org/struts/browse/WW-2795
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.2
>            Reporter: Raphael Kirchner
>            Priority: Minor
>             Fix For: 2.1.3
>
>
> According to JavaDoc, org.apache.struts2.interceptor.NoParameters should be "should be implemented by actions that do not want any parameters set on them automatically. This may be useful if one is using the action tag and want to supply the parameters to the action manually using the param tag."
> Actually something like the opposite happens: The action tag param gets blocked and the request param is used instead
> Example:
> 		<@s.action name="Foo" executeResult="true" ignoreContextParams="true" >
> 			<@s.param name="input">embedded</@>
> 		</...@s.action>
> With Foo implementing NoParams,
>    1) Foo.action results in Foo.input == NULL
>    2) Foo.action?input=test results in Foo.input == "test"
> Where it should be "embedded" in both cases.
> 		<@s.action name="Foo" executeResult="true" ignoreContextParams="true" >
> 		</...@s.action>
> With Foo implementing NoParams,
>    1) Foo.action results in Foo.input == NULL
>    2) Foo.action?input?test results in Foo.input == "test"
> Where it should be NULL in both cases,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.