You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by colindean <gi...@git.apache.org> on 2018/11/05 21:26:08 UTC

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

Github user colindean commented on the issue:

    https://github.com/apache/nifi/pull/3133
  
    > If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    I added properties but I used a readable string for `.name`.
    
    > Have you written or updated unit tests to verify your changes?
    
    I'm not sure how best I can _operationally_ test these, or if that makes sense because we'd be testing the API functionality of commons-dbcp…


---