You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/02 15:11:55 UTC
[GitHub] [pulsar] jiazhai opened a new pull request #6458: change to not
include openssl in libpulsar.a
jiazhai opened a new pull request #6458: change to not include openssl in libpulsar.a
URL: https://github.com/apache/pulsar/pull/6458
We shouldn't static link libssl in libpulsar.a, as this is a security red flag. we should just use whatever the libssl the system provides. Because if there is a security problem in libssl, all the machines can just update their own libssl library without rebuilding libpulsar.a.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6458: Improve cpp-client-lib:
provide another `libpulsarwithdeps.a` in dep/rpm
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6458: Improve cpp-client-lib: provide another `libpulsarwithdeps.a` in dep/rpm
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-599164315
@aahmed-se @sijie updated to create separate additional libs for requirements, not changed the old behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6458: change to not include
openssl in libpulsar.a
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6458: change to not include openssl in libpulsar.a
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-594336463
@jiazhai @aahmed-se how about introducing a new static library that doesn't link libssl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6458: change to not include
openssl in libpulsar.a
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6458: change to not include openssl in libpulsar.a
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-593584183
@jiazhai Can you make sure the documentation is updated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6458: Improve cpp-client-lib:
provide another `libpulsarwithdeps.a` in dep/rpm
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6458: Improve cpp-client-lib: provide another `libpulsarwithdeps.a` in dep/rpm
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-599164203
rebased with latest master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6458: change to not include
openssl in libpulsar.a
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6458: change to not include openssl in libpulsar.a
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-594342585
@sijie Ok. I will try to add a new static library
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #6458: change to not include
openssl in libpulsar.a
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #6458: change to not include openssl in libpulsar.a
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-594237453
@jiazhai @sijie This will most likely break the python wheel files for mac, by default osx does not have ssl installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai merged pull request #6458: Improve cpp-client-lib:
provide another `libpulsarwithdeps.a` in dep/rpm
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #6458: Improve cpp-client-lib: provide another `libpulsarwithdeps.a` in dep/rpm
URL: https://github.com/apache/pulsar/pull/6458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #6458: change to not include
openssl in libpulsar.a
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #6458: change to not include openssl in libpulsar.a
URL: https://github.com/apache/pulsar/pull/6458#issuecomment-593841259
@merlimat can you please take a look.
I think it should be configurable but we should have the option to include libssl in the static binary if the user would like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services