You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/10 17:09:44 UTC

[GitHub] [camel] luigidemasi commented on pull request #4573: CAMEL-15822: [camel-file] fileExist=Move doesn't use FileMoveExisting…

luigidemasi commented on pull request #4573:
URL: https://github.com/apache/camel/pull/4573#issuecomment-724839537


   > I am okay with the little duplicate code. However it would be good with a bit of code comments (eg // xxxx) what the purpose is for the code, as it does a bit of path manipulation but it may not be so easy to know why (and git blame may get harder to track down over time)
   
   I did both, I moved the duplicated code in a common utility class and added the javadoc, hope it make sense.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org