[PR] Fix PropertiesConfigPageGroup visitor recursion [polaris]

["venkateshwaracholan (via GitHub)" <gi...@apache.org>]

venkateshwaracholan opened a new pull request, #4823:
URL: https://github.com/apache/polaris/pull/4823

   ## Summary
   
   
   
   This change fixes a recursion issue in `PropertiesConfigPageGroup.visitType()` that could cause configuration documentation generation to fail with a `StackOverflowError` when processing nested types inside a `@ConfigPageGroup`.
   
   The previous implementation recursively revisited the same `TypeElement` using `e.accept(this, env)`. When nested classes, interfaces, or records were present, this resulted in the visitor repeatedly dispatching to itself instead of traversing the enclosed elements, eventually exhausting the call stack.
   
   To resolve this, the visitor now processes the type's enclosed elements directly. This aligns the implementation with the traversal approach already used in `PropertiesConfigs` and ensures nested configuration elements are handled correctly.
   
   ## Changes
   
   * Replaced self-recursive `TypeElement` visitation with traversal of enclosed elements.
   * Added regression tests covering nested classes, interfaces, and records.
   * No public API changes.
   * No behavioral changes outside of the configuration documentation generator.
   
   
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #4822
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix PropertiesConfigPageGroup visitor recursion [polaris]

["adutra (via GitHub)" <gi...@apache.org>]

adutra merged PR #4823:
URL: https://github.com/apache/polaris/pull/4823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org