You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/09/10 02:30:29 UTC
Review Request 38241: Fixed an issue that caused provisioned
filesystems specified in --default_container_info to be not recovered.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38241/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Fixed an issue that caused provisioned filesystems specified in --default_container_info to be not recovered.
Diffs
-----
src/slave/containerizer/provisioners/appc/appc.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38241/diff/
Testing
-------
Tested in https://reviews.apache.org/r/38075/
Thanks,
Jiang Yan Xu
Re: Review Request 38241: Fixed an issue that caused provisioned
filesystems specified in --default_container_info to be not recovered.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38241/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 11:32 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Comments. NNRF.
Repository: mesos
Description
-------
Fixed an issue that caused provisioned filesystems specified in --default_container_info to be not recovered.
Diffs (updated)
-----
src/slave/containerizer/provisioners/appc/provisioner.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38241/diff/
Testing
-------
Tested in https://reviews.apache.org/r/38075/
Thanks,
Jiang Yan Xu
Re: Review Request 38241: Fixed an issue that caused provisioned
filesystems specified in --default_container_info to be not recovered.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38241/#review98443
-----------------------------------------------------------
Ship it!
src/slave/containerizer/provisioners/appc/provisioner.cpp (line 272)
<https://reviews.apache.org/r/38241/#comment154918>
quote is not needed for containerId as it's generated by us (shouldn't contain spaces).
- Jie Yu
On Sept. 10, 2015, 6:59 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38241/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 6:59 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an issue that caused provisioned filesystems specified in --default_container_info to be not recovered.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioners/appc/provisioner.cpp d54b6882346df7121ec63803810fab979ac0848a
>
> Diff: https://reviews.apache.org/r/38241/diff/
>
>
> Testing
> -------
>
> Tested in https://reviews.apache.org/r/38075/
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 38241: Fixed an issue that caused provisioned
filesystems specified in --default_container_info to be not recovered.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38241/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 11:59 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Fixed an issue that caused provisioned filesystems specified in --default_container_info to be not recovered.
Diffs (updated)
-----
src/slave/containerizer/provisioners/appc/provisioner.cpp d54b6882346df7121ec63803810fab979ac0848a
Diff: https://reviews.apache.org/r/38241/diff/
Testing
-------
Tested in https://reviews.apache.org/r/38075/
Thanks,
Jiang Yan Xu