You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/11 15:42:11 UTC
[jira] [Commented] (JENA-1085) Review trasnaction finishes for
DatasetGraphInMemory
[ https://issues.apache.org/jira/browse/JENA-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052844#comment-15052844 ]
ASF GitHub Bot commented on JENA-1085:
--------------------------------------
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/107
JENA-1085 : Common pattern for passing down transaction lifecycle operations.
* Abort called `end` directly causing the warning to be emitted
* Abort did not call quadIndex.abort/defaultGraph.abort
* Pair up quadIndex.end/defaultGraph.end for read transactions
* Add locks around all pairs of quadIndex, defaultGraph operation calls
Discussion points:
* `writeLock` is used even for read transactions (it's a no-op but it's called). Shoudl we rename it as e.g. `readerWriterLock`?
* `TupleTable.abort` defaults to end. Given the importance of the transaction cycle, might it be better to require each implementation to do that. It puts all the begin/commit/abort/end code for one component in one place for the next person to look at the code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 39af9c3b447b56c2f237af43c0b5ffb5fa287bce
Author: Andy Seaborne <an...@apache.org>
Date: 2015-12-11T14:28:48Z
Cleanly abort a write transaction.
commit c709ef793bf2f99e8ed951e67509679a36f6af7b
Author: Andy Seaborne <an...@apache.org>
Date: 2015-12-11T14:29:58Z
JENA-1078: Silence warnings.
This calls tests error conditions makign logged warnings expected.
commit 2cfa0e30aabebb069921a3187a57f17ec1d37310
Author: Andy Seaborne <an...@apache.org>
Date: 2015-12-11T14:38:07Z
JENA-1085: Always pass down transaction lifecycle calls.
* Abort called `end` directly causing the warning to be emitted
* Abort did not call quadIndex.abort/defaultGraph.abort
* Pair up quadIndex.end/defaultGraph.end for read transactions
* Add locks around all pairs of quadIndex, defaultGraph operation calls
----
> Review trasnaction finishes for DatasetGraphInMemory
> ----------------------------------------------------
>
> Key: JENA-1085
> URL: https://issues.apache.org/jira/browse/JENA-1085
> Project: Apache Jena
> Issue Type: Task
> Components: ARQ
> Affects Versions: Jena 3.0.1
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
> Fix For: Jena 3.1.0
>
>
> This JIRA is for a review of the transaction finishing code.
> Some of the code works because of the nature of specific implementations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)