You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "wecharyu (via GitHub)" <gi...@apache.org> on 2025/08/28 16:29:40 UTC
[PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
wecharyu opened a new pull request, #6047:
URL: https://github.com/apache/hive/pull/6047
### What changes were proposed in this pull request?
Use filesystem's `access()` api to check permission.
### Why are the changes needed?
The permission modes vary in different filesystems, we could not just check permissions based on the group mode.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Removed the `supergroup` test and add a new test in `TestHdfsUtils`.
```bash
mvn test -Dtest.groups= -Dtest=org.apache.hadoop.hive.metastore.utils.TestHdfsUtils -pl :hive-standalone-metastore-server
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6047:
URL: https://github.com/apache/hive/pull/6047#issuecomment-3234495336
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6047) **Quality Gate passed**
Issues
 [104 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6047&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6047&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6047&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6047&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6047&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6047)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6047:
URL: https://github.com/apache/hive/pull/6047#issuecomment-3236919756
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6047) **Quality Gate passed**
Issues
 [104 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6047&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6047&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6047&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6047&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6047&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6047)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao merged PR #6047:
URL: https://github.com/apache/hive/pull/6047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6047:
URL: https://github.com/apache/hive/pull/6047#issuecomment-3259321909
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6047) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6047&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6047&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6047&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6047&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6047&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6047)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "wecharyu (via GitHub)" <gi...@apache.org>.
wecharyu commented on code in PR #6047:
URL: https://github.com/apache/hive/pull/6047#discussion_r2319480663
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
##########
@@ -65,57 +64,35 @@ public class HdfsUtils {
/**
* Check the permissions on a file.
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
- public static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action)
- throws IOException, LoginException {
- checkFileAccess(fs, stat, action, SecurityUtils.getUGI());
+ public static void checkFileAccess(FileSystem fs, Path path, FsAction action)
+ throws IOException {
+ checkFileAccess(fs, path, action, SecurityUtils.getUGI());
}
/**
* Check the permissions on a file
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @param ugi user group info for the current user. This is passed in so that tests can pass
* in mock ones.
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
@VisibleForTesting
- static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action,
+ static void checkFileAccess(FileSystem fs, Path path, FsAction action,
UserGroupInformation ugi) throws IOException {
-
- String user = ugi.getShortUserName();
- String[] groups = ugi.getGroupNames();
-
- if (groups != null) {
- String superGroupName = fs.getConf().get("dfs.permissions.supergroup", "");
- if (arrayContains(groups, superGroupName)) {
- LOG.debug("User \"" + user + "\" belongs to super-group \"" + superGroupName + "\". " +
- "Permission granted for action: " + action + ".");
- return;
- }
- }
-
- FsPermission dirPerms = stat.getPermission();
-
- if (user.equals(stat.getOwner())) {
- if (dirPerms.getUserAction().implies(action)) {
- return;
- }
- } else if (arrayContains(groups, stat.getGroup())) {
- if (dirPerms.getGroupAction().implies(action)) {
- return;
- }
- } else if (dirPerms.getOtherAction().implies(action)) {
- return;
+ try {
+ ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ fs.access(path, action);
Review Comment:
Yes, hdfs `access()` API will also skip checkPermission for super user:
https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a08322b78422849b1/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java#L1954-L1960
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
##########
@@ -65,57 +64,35 @@ public class HdfsUtils {
/**
* Check the permissions on a file.
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
- public static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action)
- throws IOException, LoginException {
- checkFileAccess(fs, stat, action, SecurityUtils.getUGI());
+ public static void checkFileAccess(FileSystem fs, Path path, FsAction action)
+ throws IOException {
+ checkFileAccess(fs, path, action, SecurityUtils.getUGI());
}
/**
* Check the permissions on a file
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @param ugi user group info for the current user. This is passed in so that tests can pass
* in mock ones.
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
@VisibleForTesting
- static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action,
+ static void checkFileAccess(FileSystem fs, Path path, FsAction action,
UserGroupInformation ugi) throws IOException {
-
- String user = ugi.getShortUserName();
- String[] groups = ugi.getGroupNames();
-
- if (groups != null) {
- String superGroupName = fs.getConf().get("dfs.permissions.supergroup", "");
- if (arrayContains(groups, superGroupName)) {
- LOG.debug("User \"" + user + "\" belongs to super-group \"" + superGroupName + "\". " +
- "Permission granted for action: " + action + ".");
- return;
- }
- }
-
- FsPermission dirPerms = stat.getPermission();
-
- if (user.equals(stat.getOwner())) {
- if (dirPerms.getUserAction().implies(action)) {
- return;
- }
- } else if (arrayContains(groups, stat.getGroup())) {
- if (dirPerms.getGroupAction().implies(action)) {
- return;
- }
- } else if (dirPerms.getOtherAction().implies(action)) {
- return;
+ try {
+ ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ fs.access(path, action);
+ return null;
+ });
+ } catch (InterruptedException e) {
+ throw new IOException(e);
Review Comment:
`AccessControlException` will be thrown directly, and `InterruptedException` is usually not related to permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #6047:
URL: https://github.com/apache/hive/pull/6047#discussion_r2317588920
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
##########
@@ -65,57 +64,35 @@ public class HdfsUtils {
/**
* Check the permissions on a file.
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
- public static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action)
- throws IOException, LoginException {
- checkFileAccess(fs, stat, action, SecurityUtils.getUGI());
+ public static void checkFileAccess(FileSystem fs, Path path, FsAction action)
+ throws IOException {
+ checkFileAccess(fs, path, action, SecurityUtils.getUGI());
}
/**
* Check the permissions on a file
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @param ugi user group info for the current user. This is passed in so that tests can pass
* in mock ones.
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
@VisibleForTesting
- static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action,
+ static void checkFileAccess(FileSystem fs, Path path, FsAction action,
UserGroupInformation ugi) throws IOException {
-
- String user = ugi.getShortUserName();
- String[] groups = ugi.getGroupNames();
-
- if (groups != null) {
- String superGroupName = fs.getConf().get("dfs.permissions.supergroup", "");
- if (arrayContains(groups, superGroupName)) {
- LOG.debug("User \"" + user + "\" belongs to super-group \"" + superGroupName + "\". " +
- "Permission granted for action: " + action + ".");
- return;
- }
- }
-
- FsPermission dirPerms = stat.getPermission();
-
- if (user.equals(stat.getOwner())) {
- if (dirPerms.getUserAction().implies(action)) {
- return;
- }
- } else if (arrayContains(groups, stat.getGroup())) {
- if (dirPerms.getGroupAction().implies(action)) {
- return;
- }
- } else if (dirPerms.getOtherAction().implies(action)) {
- return;
+ try {
+ ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ fs.access(path, action);
Review Comment:
**In case of hdfs filesystem**, If user A belongs to the superuser group `fs.getConf().get("dfs.permissions.supergroup", "")`, then user A should have all permissions.
Can the `fs.access(path, action)` determine whether user A has all permissions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "wecharyu (via GitHub)" <gi...@apache.org>.
wecharyu commented on PR #6047:
URL: https://github.com/apache/hive/pull/6047#issuecomment-3236596963
@ayushtkn @deniskuzZ @zhangbutao could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #6047:
URL: https://github.com/apache/hive/pull/6047#discussion_r2317561429
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
##########
@@ -65,57 +64,35 @@ public class HdfsUtils {
/**
* Check the permissions on a file.
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
- public static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action)
- throws IOException, LoginException {
- checkFileAccess(fs, stat, action, SecurityUtils.getUGI());
+ public static void checkFileAccess(FileSystem fs, Path path, FsAction action)
+ throws IOException {
+ checkFileAccess(fs, path, action, SecurityUtils.getUGI());
}
/**
* Check the permissions on a file
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @param ugi user group info for the current user. This is passed in so that tests can pass
* in mock ones.
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
@VisibleForTesting
- static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action,
+ static void checkFileAccess(FileSystem fs, Path path, FsAction action,
UserGroupInformation ugi) throws IOException {
-
- String user = ugi.getShortUserName();
- String[] groups = ugi.getGroupNames();
-
- if (groups != null) {
- String superGroupName = fs.getConf().get("dfs.permissions.supergroup", "");
- if (arrayContains(groups, superGroupName)) {
- LOG.debug("User \"" + user + "\" belongs to super-group \"" + superGroupName + "\". " +
- "Permission granted for action: " + action + ".");
- return;
- }
- }
-
- FsPermission dirPerms = stat.getPermission();
-
- if (user.equals(stat.getOwner())) {
- if (dirPerms.getUserAction().implies(action)) {
- return;
- }
- } else if (arrayContains(groups, stat.getGroup())) {
- if (dirPerms.getGroupAction().implies(action)) {
- return;
- }
- } else if (dirPerms.getOtherAction().implies(action)) {
- return;
+ try {
+ ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ fs.access(path, action);
+ return null;
+ });
+ } catch (InterruptedException e) {
+ throw new IOException(e);
Review Comment:
Why not throw `AccessControlException`?
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java:
##########
@@ -74,7 +73,7 @@
public class SecurityUtils {
private static final Logger LOG = LoggerFactory.getLogger(SecurityUtils.class);
- public static UserGroupInformation getUGI() throws LoginException, IOException {
Review Comment:
That's ok
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
##########
@@ -65,57 +64,35 @@ public class HdfsUtils {
/**
* Check the permissions on a file.
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
- public static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action)
- throws IOException, LoginException {
- checkFileAccess(fs, stat, action, SecurityUtils.getUGI());
+ public static void checkFileAccess(FileSystem fs, Path path, FsAction action)
+ throws IOException {
+ checkFileAccess(fs, path, action, SecurityUtils.getUGI());
}
/**
* Check the permissions on a file
* @param fs Filesystem the file is contained in
- * @param stat Stat info for the file
+ * @param path the file path
* @param action action to be performed
* @param ugi user group info for the current user. This is passed in so that tests can pass
* in mock ones.
* @throws IOException If thrown by Hadoop
- * @throws AccessControlException if the file cannot be accessed
*/
@VisibleForTesting
- static void checkFileAccess(FileSystem fs, FileStatus stat, FsAction action,
+ static void checkFileAccess(FileSystem fs, Path path, FsAction action,
UserGroupInformation ugi) throws IOException {
-
- String user = ugi.getShortUserName();
- String[] groups = ugi.getGroupNames();
-
- if (groups != null) {
- String superGroupName = fs.getConf().get("dfs.permissions.supergroup", "");
- if (arrayContains(groups, superGroupName)) {
- LOG.debug("User \"" + user + "\" belongs to super-group \"" + superGroupName + "\". " +
- "Permission granted for action: " + action + ".");
- return;
- }
- }
-
- FsPermission dirPerms = stat.getPermission();
-
- if (user.equals(stat.getOwner())) {
- if (dirPerms.getUserAction().implies(action)) {
- return;
- }
- } else if (arrayContains(groups, stat.getGroup())) {
- if (dirPerms.getGroupAction().implies(action)) {
- return;
- }
- } else if (dirPerms.getOtherAction().implies(action)) {
- return;
+ try {
+ ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ fs.access(path, action);
Review Comment:
If user A belongs to the superuser group `fs.getConf().get("dfs.permissions.supergroup", "")`, then user A should have all permissions.
Can the `fs.access(path, action)` determine whether user A has all permissions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #6047:
URL: https://github.com/apache/hive/pull/6047#issuecomment-3257211455
LGTM
@wecharyu Please rebase to fix the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29167: Use access() api to check permission for different filesystems [hive]
Posted by "wecharyu (via GitHub)" <gi...@apache.org>.
wecharyu commented on code in PR #6047:
URL: https://github.com/apache/hive/pull/6047#discussion_r2307951035
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java:
##########
@@ -74,7 +73,7 @@
public class SecurityUtils {
private static final Logger LOG = LoggerFactory.getLogger(SecurityUtils.class);
- public static UserGroupInformation getUGI() throws LoginException, IOException {
Review Comment:
The `LoginException` would never be thrown, I consider to remove all uses of it in a new PR because it's not quite relative to current PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org