You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2019/02/15 21:25:10 UTC

[GitHub] grahamtriggs commented on issue #533: Feature/sdborder

grahamtriggs commented on issue #533: Feature/sdborder
URL: https://github.com/apache/jena/pull/533#issuecomment-464205740
 
 
   Functionally, the LinkedHastSet (order of Scope), and DISTINCT / GROUP BY translation are tested multiple times during the existing tests - the code is exercised and affects the SQL generated without breaking any of the tests.
   
   The ORDER BY translation currently isn't because it's disabled by default, but it could be turned on for the tests (and again it doesn't break any existing tests).
   
   I'll have a think about what tests could be included to ensure that the SQL translations occur as expected, beyond just testing the execution of the query.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services