You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:53:10 UTC
Re: Review Request 66284: Tested `max_completion_time` support in
docker executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/
-----------------------------------------------------------
(Updated April 7, 2018, 5:53 p.m.)
Review request for mesos, Jason Lai and James Peach.
Changes
-------
Updated test according to rename.
Summary (updated)
-----------------
Tested `max_completion_time` support in docker executor.
Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725
Repository: mesos
Description (updated)
-------
Tested `max_completion_time` support in docker executor.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7
Diff: https://reviews.apache.org/r/66284/diff/2/
Changes: https://reviews.apache.org/r/66284/diff/1-2/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 66284: Tested `max_completion_time` support in
docker executor.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/#review201132
-----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 646 (patched)
<https://reviews.apache.org/r/66284/#comment282142>
Use `createTask()` here?
```
TaskInfo task = createTask(
offer.slave_id(),
offer.resources(),
SLEEP_COMMAND(1000));
```
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 688 (patched)
<https://reviews.apache.org/r/66284/#comment282165>
Consolidate this into the `EXPECT_CALL` above?
- James Peach
On April 8, 2018, 12:53 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66284/
> -----------------------------------------------------------
>
> (Updated April 8, 2018, 12:53 a.m.)
>
>
> Review request for mesos, Jason Lai and James Peach.
>
>
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Tested `max_completion_time` support in docker executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 847258daadf3c37d9071151616b18fc79d850ce8
>
>
> Diff: https://reviews.apache.org/r/66284/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 66284: Tested `max_completion_time` support in
docker executor.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/#review202155
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 630 (patched)
<https://reviews.apache.org/r/66284/#comment283792>
Rebase onto master and use local helper:
```
// TODO(tnachen): Use local image to test if possible.
task.mutable_container()->CopyFrom(createDockerInfo("alpine"));
```
- James Peach
On April 27, 2018, 4:09 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66284/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 4:09 p.m.)
>
>
> Review request for mesos, Jason Lai and James Peach.
>
>
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Tested `max_completion_time` support in docker executor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 5e3dfdb537f52a85a82c6e8195e70a389b76aadf
>
>
> Diff: https://reviews.apache.org/r/66284/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 66284: Tested `max_completion_time` support in
docker executor.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/
-----------------------------------------------------------
(Updated May 1, 2018, 9:42 a.m.)
Review request for mesos, Jason Lai and James Peach.
Changes
-------
Review comments.
Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725
Repository: mesos
Description
-------
Tested `max_completion_time` support in docker executor.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp 5e3dfdb537f52a85a82c6e8195e70a389b76aadf
Diff: https://reviews.apache.org/r/66284/diff/5/
Changes: https://reviews.apache.org/r/66284/diff/4-5/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 66284: Tested `max_completion_time` support in
docker executor.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/
-----------------------------------------------------------
(Updated April 27, 2018, 9:09 a.m.)
Review request for mesos, Jason Lai and James Peach.
Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725
Repository: mesos
Description
-------
Tested `max_completion_time` support in docker executor.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp 5e3dfdb537f52a85a82c6e8195e70a389b76aadf
Diff: https://reviews.apache.org/r/66284/diff/4/
Changes: https://reviews.apache.org/r/66284/diff/3-4/
Testing
-------
Thanks,
Zhitao Li