You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/15 07:27:22 UTC
[GitHub] [doris] liaoxin01 opened a new pull request, #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
liaoxin01 opened a new pull request, #15101:
URL: https://github.com/apache/doris/pull/15101
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352702563
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.63 seconds
load time: 447 seconds
storage size: 17123356910 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221215081630_clickbench_pr_63792.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1357003933
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352932527
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352710521
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352786556
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15101:
URL: https://github.com/apache/doris/pull/15101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352664900
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #15101:
URL: https://github.com/apache/doris/pull/15101#discussion_r1049445941
##########
gensrc/proto/internal_service.proto:
##########
@@ -65,6 +65,8 @@ message PTabletInfo {
// Delta Writer will write data to local disk and then check if there are new raw values not in global dict
// if appears, then it should add the column name to this vector
repeated string invalid_dict_cols = 3;
+ // total rows num written by DeltaWriter
+ optional int64 num_rows = 4;
Review Comment:
change to received_rows is better? num_rows sounds like the number written to file.
##########
be/src/olap/delta_writer.h:
##########
@@ -110,6 +110,8 @@ class DeltaWriter {
void finish_slave_tablet_pull_rowset(int64_t node_id, bool is_succeed);
+ int64_t total_rows() const { return _total_rows; }
Review Comment:
_total_received_rows is more clear
##########
be/src/olap/delta_writer.cpp:
##########
@@ -358,6 +362,12 @@ Status DeltaWriter::close_wait(const PSlaveTabletNodes& slave_tablet_nodes,
_mem_table.reset();
+ if (_rowset_writer->num_rows() + _merged_rows != _total_rows) {
+ LOG(WARNING) << "the rows number written doesn't match, rowset num_rows: "
Review Comment:
`rowset num_rows:` -> `rowset num rows written to file:`
`total_rows: ` -> `total received rows`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1360645778
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352765217
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liaoxin01 commented on a diff in pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #15101:
URL: https://github.com/apache/doris/pull/15101#discussion_r1049527499
##########
be/src/olap/delta_writer.h:
##########
@@ -110,6 +110,8 @@ class DeltaWriter {
void finish_slave_tablet_pull_rowset(int64_t node_id, bool is_succeed);
+ int64_t total_rows() const { return _total_rows; }
Review Comment:
Yes, it is more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352924140
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liaoxin01 commented on a diff in pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #15101:
URL: https://github.com/apache/doris/pull/15101#discussion_r1049527760
##########
gensrc/proto/internal_service.proto:
##########
@@ -65,6 +65,8 @@ message PTabletInfo {
// Delta Writer will write data to local disk and then check if there are new raw values not in global dict
// if appears, then it should add the column name to this vector
repeated string invalid_dict_cols = 3;
+ // total rows num written by DeltaWriter
+ optional int64 num_rows = 4;
Review Comment:
fixed.
##########
be/src/olap/delta_writer.cpp:
##########
@@ -358,6 +362,12 @@ Status DeltaWriter::close_wait(const PSlaveTabletNodes& slave_tablet_nodes,
_mem_table.reset();
+ if (_rowset_writer->num_rows() + _merged_rows != _total_rows) {
+ LOG(WARNING) << "the rows number written doesn't match, rowset num_rows: "
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1352934893
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15101: [enhancement](load) verify the number of rows between different replicas when load data to avoid data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15101:
URL: https://github.com/apache/doris/pull/15101#issuecomment-1360669208
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org