You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/13 03:11:41 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk

xiaoxiang781216 commented on a change in pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#discussion_r453412389



##########
File path: boards/arm/stm32/b-g474e-dpow1/scripts/Make.defs
##########
@@ -85,10 +85,6 @@ endif
 # Provide map file needed by the "Memory Allocation" view in Eclipse:
 LDFLAGS += -Map=$(TOPDIR)/NuttX.map --gc-sections
 
-HOSTCC = gcc
-HOSTINCLUDES = -I.

Review comment:
       No, because many boards don't add -I. without any problem, and C compiler search the current directory by default(#include "xxx.h".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org